Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(195)

Issue 2276523002: Cleanup |initTouchEvent| deprecation warning and usecounter (Closed)

Created:
4 years, 4 months ago by chongz
Modified:
4 years, 4 months ago
Reviewers:
bokan, Rick Byers
CC:
chromium-reviews, blink-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Cleanup |initTouchEvent| deprecation warning and usecounter |TouchEvent.initTouchEvent()| was removed in M54, so we no longer need these deprecation warning and usercounter. See https://chromium.googlesource.com/chromium/src.git/+/44cc3124a56262d937b36a3d6d0d3de626082716 BUG=522100 Committed: https://crrev.com/843b0c5cf6cbcb96d5e1314e37f041e7d2da1959 Cr-Commit-Position: refs/heads/master@{#413919}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -4 lines) Patch
M third_party/WebKit/Source/core/frame/Deprecation.cpp View 1 chunk +0 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/core/frame/UseCounter.h View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 17 (8 generated)
chongz
bokan@ PTAL, thanks!
4 years, 4 months ago (2016-08-23 15:38:34 UTC) #3
chongz
rbyers@ PTAL, thanks! (Seems bokan@ is OOO)
4 years, 4 months ago (2016-08-23 20:03:38 UTC) #5
bokan
On 2016/08/23 20:03:38, chongz wrote: > rbyers@ PTAL, thanks! > (Seems bokan@ is OOO) Bokan ...
4 years, 4 months ago (2016-08-23 20:44:23 UTC) #6
bokan
lgtm
4 years, 4 months ago (2016-08-23 20:49:17 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2276523002/1
4 years, 4 months ago (2016-08-23 21:12:05 UTC) #9
commit-bot: I haz the power
Try jobs failed on following builders: linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/linux_android_rel_ng/builds/128251)
4 years, 4 months ago (2016-08-23 23:03:37 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2276523002/1
4 years, 4 months ago (2016-08-24 00:09:51 UTC) #13
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 4 months ago (2016-08-24 01:06:12 UTC) #15
commit-bot: I haz the power
4 years, 4 months ago (2016-08-24 01:09:26 UTC) #17
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/843b0c5cf6cbcb96d5e1314e37f041e7d2da1959
Cr-Commit-Position: refs/heads/master@{#413919}

Powered by Google App Engine
This is Rietveld 408576698