Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(59)

Issue 2276483003: Store NonLocals in variables_ (Closed)

Created:
4 years, 4 months ago by Toon Verwaest
Modified:
4 years, 4 months ago
Reviewers:
adamk
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Store NonLocals in variables_ Now that ordered_variables_ is used to find non-dynamic variables, and NonLocals are always stored in the scope that introduces them, we can rely on variables_ to also cache non-locals. This has 2 advantages: 1) we don't need DynamicScopePart anymore, reducing all scopes by a pointer 2) upon second lookup of a non-local we don't need to walk the entire chain anymore. The cached value will immediately be found. BUG=v8:5209 Committed: https://crrev.com/3a9c7b55af27105c482e9449911b010f46830cb4 Cr-Commit-Position: refs/heads/master@{#38855}

Patch Set 1 #

Total comments: 1

Patch Set 2 : Separate printing of dynamics and locals #

Patch Set 3 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+17 lines, -49 lines) Patch
M src/ast/scopes.h View 2 chunks +0 lines, -24 lines 0 comments Download
M src/ast/scopes.cc View 1 4 chunks +17 lines, -25 lines 0 comments Download

Messages

Total messages: 12 (4 generated)
Toon Verwaest
ptal
4 years, 4 months ago (2016-08-23 21:06:45 UTC) #2
adamk
In your CL description, you say that ordered_variables_ is used to "find non-dynamic variables". But ...
4 years, 4 months ago (2016-08-23 22:12:20 UTC) #3
Toon Verwaest
Addressed printing comment. Sorry, I didn't mean find in the LookupLocal sense, but for variable ...
4 years, 4 months ago (2016-08-23 23:50:38 UTC) #4
adamk
lgtm Thanks for the explanation. I'm sympathetic to not wanting to spend an extra pointer ...
4 years, 4 months ago (2016-08-24 00:02:24 UTC) #5
Toon Verwaest
Indeed. As described in the doc, I'm also thinking of resolving variables as we close ...
4 years, 4 months ago (2016-08-24 04:45:21 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2276483003/40001
4 years, 4 months ago (2016-08-24 04:47:40 UTC) #9
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years, 4 months ago (2016-08-24 08:51:59 UTC) #10
commit-bot: I haz the power
4 years, 4 months ago (2016-08-24 08:52:13 UTC) #12
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/3a9c7b55af27105c482e9449911b010f46830cb4
Cr-Commit-Position: refs/heads/master@{#38855}

Powered by Google App Engine
This is Rietveld 408576698