Add new wayland request to enter screen locking mode.

Add new wayland request to enter screen locking mode.

The CL adds a new wayland request 'pin_with_trusted_flag' that replaces the
existing request 'pin'. The new request takes a trusted flag so that trusted
apps can be allowed to enforce users to stay in pinned mode.

The CL also adds new window state 'trusted_pinned' which will be used in further implementation to specify pinned state invoked by trusted apps.

BUG=b/29325086
TEST=None

Committed: https://crrev.com/f6a61224b071a2f611747797d2060aebc5d7d770
Cr-Commit-Position: refs/heads/master@{#414334}

[hirono, 2016-08-23 10:32:51]

Description was changed from

==========
Add new wayland request to enter screen locking mode.

The CL adds a new wayland request 'pin_with_trusted_flag' that replaces the
existing request 'pin'. The new request takes a trusted flag so that trusted
apps can be allowed to enforce users to stay in pinned mode.

The CL also adds new window state 'locked'.

BUG=
==========

to

==========
Add new wayland request to enter screen locking mode.

The CL adds a new wayland request 'pin_with_trusted_flag' that replaces the
existing request 'pin'. The new request takes a trusted flag so that trusted
apps can be allowed to enforce users to stay in pinned mode.

The CL also adds new window state 'trusted_pinned' which will be used in further
implementation to specify pinned state invoked by trusted apps.

BUG=b/29325086
TEST=None
==========

[hirono, 2016-08-23 10:33:27]

hirono@chromium.org changed reviewers:
+ hidehiko@chromium.org

[hirono, 2016-08-23 10:33:28]

PTAL, thank you!

[hidehiko, 2016-08-24 16:13:12]

hidehiko@chromium.org changed reviewers:
+ reveman@chromium.org

[hidehiko, 2016-08-24 16:13:12]

Could you run scanner to the xml, so that other headers will be auto-generated?

David, could you also take a look, too?

https://codereview.chromium.org/2276443002/diff/20001/third_party/wayland-pro...
File
third_party/wayland-protocols/unstable/remote-shell/remote-shell-unstable-v1.xml
(right):

https://codereview.chromium.org/2276443002/diff/20001/third_party/wayland-pro...
third_party/wayland-protocols/unstable/remote-shell/remote-shell-unstable-v1.xml:171:
<interface name="zwp_remote_surface_v1" version="10">
Could you update this to 11, too?

https://codereview.chromium.org/2276443002/diff/20001/third_party/wayland-pro...
third_party/wayland-protocols/unstable/remote-shell/remote-shell-unstable-v1.xml:511:
<description summary="pinWithTrustedFlag">
Could you use snake_case_name ?

https://codereview.chromium.org/2276443002/diff/20001/third_party/wayland-pro...
third_party/wayland-protocols/unstable/remote-shell/remote-shell-unstable-v1.xml:520:
<arg name="trusted" type="int" summary="whether the app can enforce usres
s/usres/users/

[reveman, 2016-08-24 18:47:47]

https://codereview.chromium.org/2276443002/diff/20001/third_party/wayland-pro...
File
third_party/wayland-protocols/unstable/remote-shell/remote-shell-unstable-v1.xml
(right):

https://codereview.chromium.org/2276443002/diff/20001/third_party/wayland-pro...
third_party/wayland-protocols/unstable/remote-shell/remote-shell-unstable-v1.xml:510:
<request name="pin" since="11">
there's already a request with this name as part of the interface. even if this
happens to work, please use a different name to avoid confusion. pin_trusted?

https://codereview.chromium.org/2276443002/diff/20001/third_party/wayland-pro...
third_party/wayland-protocols/unstable/remote-shell/remote-shell-unstable-v1.xml:511:
<description summary="pinWithTrustedFlag">
On 2016/08/24 at 16:13:12, hidehiko wrote:
> Could you use snake_case_name ?

this should be a short sentence that describes the request

[hirono, 2016-08-25 03:30:00]

> Could you run scanner to the xml, so that other headers will be
auto-generated?

I manually updated these files because I had gotten a lot of diffs after running
wayland-scanner.
crrev.com/2279643002

@reveman - Should we replace these files with auto generated version?

[hirono, 2016-08-25 03:30:12]

Thank you for reviewing!

https://codereview.chromium.org/2276443002/diff/20001/third_party/wayland-pro...
File
third_party/wayland-protocols/unstable/remote-shell/remote-shell-unstable-v1.xml
(right):

https://codereview.chromium.org/2276443002/diff/20001/third_party/wayland-pro...
third_party/wayland-protocols/unstable/remote-shell/remote-shell-unstable-v1.xml:171:
<interface name="zwp_remote_surface_v1" version="10">
On 2016/08/24 16:13:12, hidehiko wrote:
> Could you update this to 11, too?

Done.

https://codereview.chromium.org/2276443002/diff/20001/third_party/wayland-pro...
third_party/wayland-protocols/unstable/remote-shell/remote-shell-unstable-v1.xml:510:
<request name="pin" since="11">
Yes, I was confused with the name in <description summary="">. Done

https://codereview.chromium.org/2276443002/diff/20001/third_party/wayland-pro...
third_party/wayland-protocols/unstable/remote-shell/remote-shell-unstable-v1.xml:511:
<description summary="pinWithTrustedFlag">
On 2016/08/24 16:13:12, hidehiko wrote:
> Could you use snake_case_name ?

Done.

https://codereview.chromium.org/2276443002/diff/20001/third_party/wayland-pro...
third_party/wayland-protocols/unstable/remote-shell/remote-shell-unstable-v1.xml:511:
<description summary="pinWithTrustedFlag">
On 2016/08/24 16:13:12, hidehiko wrote:
> Could you use snake_case_name ?

Done.

[reveman, 2016-08-25 03:34:24]

On 2016/08/25 at 03:30:00, hirono wrote:
> > Could you run scanner to the xml, so that other headers will be
auto-generated?
> 
> I manually updated these files because I had gotten a lot of diffs after
running wayland-scanner.
> crrev.com/2279643002

you should be using the version of wayland-scanner in
src/third_party/wayland/src, version 1.11.

> 
> @reveman - Should we replace these files with auto generated version?

yes, please run wayland-scanner 1.11 to make sure they are correct.

[hirono, 2016-08-25 03:53:07]

Thank you! Updated the generated version by running wayland-scanner v1.11.
Please take another look.

[reveman, 2016-08-25 03:59:12]

lgtm

https://codereview.chromium.org/2276443002/diff/40001/third_party/wayland-pro...
File
third_party/wayland-protocols/unstable/remote-shell/remote-shell-unstable-v1.xml
(right):

https://codereview.chromium.org/2276443002/diff/40001/third_party/wayland-pro...
third_party/wayland-protocols/unstable/remote-shell/remote-shell-unstable-v1.xml:509:
<!-- Version 11 additions -->
nit: blank line after this

https://codereview.chromium.org/2276443002/diff/40001/third_party/wayland-pro...
third_party/wayland-protocols/unstable/remote-shell/remote-shell-unstable-v1.xml:518:
from exiting the pinned mode.
nit: hard to see in code review tool but please make sure this description is
indented the same way as other descriptions. mix of tabs and space..

[hirono, 2016-08-25 05:05:06]

Thank you!

https://codereview.chromium.org/2276443002/diff/40001/third_party/wayland-pro...
File
third_party/wayland-protocols/unstable/remote-shell/remote-shell-unstable-v1.xml
(right):

https://codereview.chromium.org/2276443002/diff/40001/third_party/wayland-pro...
third_party/wayland-protocols/unstable/remote-shell/remote-shell-unstable-v1.xml:509:
<!-- Version 11 additions -->
On 2016/08/25 03:59:12, reveman wrote:
> nit: blank line after this

Done.

https://codereview.chromium.org/2276443002/diff/40001/third_party/wayland-pro...
third_party/wayland-protocols/unstable/remote-shell/remote-shell-unstable-v1.xml:518:
from exiting the pinned mode.
On 2016/08/25 03:59:12, reveman wrote:
> nit: hard to see in code review tool but please make sure this description is
> indented the same way as other descriptions. mix of tabs and space.. 

Done.

[hirono, 2016-08-25 05:05:06]

Thank you!

https://codereview.chromium.org/2276443002/diff/40001/third_party/wayland-pro...
File
third_party/wayland-protocols/unstable/remote-shell/remote-shell-unstable-v1.xml
(right):

https://codereview.chromium.org/2276443002/diff/40001/third_party/wayland-pro...
third_party/wayland-protocols/unstable/remote-shell/remote-shell-unstable-v1.xml:509:
<!-- Version 11 additions -->
On 2016/08/25 03:59:12, reveman wrote:
> nit: blank line after this

Done.

https://codereview.chromium.org/2276443002/diff/40001/third_party/wayland-pro...
third_party/wayland-protocols/unstable/remote-shell/remote-shell-unstable-v1.xml:518:
from exiting the pinned mode.
On 2016/08/25 03:59:12, reveman wrote:
> nit: hard to see in code review tool but please make sure this description is
> indented the same way as other descriptions. mix of tabs and space.. 

Done.

[hirono, 2016-08-25 05:05:09]

The CQ bit was checked by hirono@chromium.org

[hirono, 2016-08-25 05:05:09]

The patchset sent to the CQ was uploaded after l-g-t-m from reveman@chromium.org
Link to the patchset: https://codereview.chromium.org/2276443002/#ps60001
(title: "Fix format.")

[commit-bot: I haz the power, 2016-08-25 05:05:47]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-25 05:55:34]

Description was changed from

==========
Add new wayland request to enter screen locking mode.

The CL adds a new wayland request 'pin_with_trusted_flag' that replaces the
existing request 'pin'. The new request takes a trusted flag so that trusted
apps can be allowed to enforce users to stay in pinned mode.

The CL also adds new window state 'trusted_pinned' which will be used in further
implementation to specify pinned state invoked by trusted apps.

BUG=b/29325086
TEST=None
==========

to

==========
Add new wayland request to enter screen locking mode.

The CL adds a new wayland request 'pin_with_trusted_flag' that replaces the
existing request 'pin'. The new request takes a trusted flag so that trusted
apps can be allowed to enforce users to stay in pinned mode.

The CL also adds new window state 'trusted_pinned' which will be used in further
implementation to specify pinned state invoked by trusted apps.

BUG=b/29325086
TEST=None
==========

[commit-bot: I haz the power, 2016-08-25 05:55:35]

Committed patchset #4 (id:60001)

[commit-bot: I haz the power, 2016-08-25 05:57:06]

Description was changed from

==========
Add new wayland request to enter screen locking mode.

The CL adds a new wayland request 'pin_with_trusted_flag' that replaces the
existing request 'pin'. The new request takes a trusted flag so that trusted
apps can be allowed to enforce users to stay in pinned mode.

The CL also adds new window state 'trusted_pinned' which will be used in further
implementation to specify pinned state invoked by trusted apps.

BUG=b/29325086
TEST=None
==========

to

==========
Add new wayland request to enter screen locking mode.

The CL adds a new wayland request 'pin_with_trusted_flag' that replaces the
existing request 'pin'. The new request takes a trusted flag so that trusted
apps can be allowed to enforce users to stay in pinned mode.

The CL also adds new window state 'trusted_pinned' which will be used in further
implementation to specify pinned state invoked by trusted apps.

BUG=b/29325086
TEST=None

Committed: https://crrev.com/f6a61224b071a2f611747797d2060aebc5d7d770
Cr-Commit-Position: refs/heads/master@{#414334}
==========

[commit-bot: I haz the power, 2016-08-25 05:57:07]

Patchset 4 (id:??) landed as
https://crrev.com/f6a61224b071a2f611747797d2060aebc5d7d770
Cr-Commit-Position: refs/heads/master@{#414334}

[hidehiko, 2016-08-25 06:19:40]

https://codereview.chromium.org/2276443002/diff/20001/third_party/wayland-pro...
File
third_party/wayland-protocols/unstable/remote-shell/remote-shell-unstable-v1.xml
(right):

https://codereview.chromium.org/2276443002/diff/20001/third_party/wayland-pro...
third_party/wayland-protocols/unstable/remote-shell/remote-shell-unstable-v1.xml:511:
<description summary="pinWithTrustedFlag">
On 2016/08/24 18:47:47, reveman wrote:
> On 2016/08/24 at 16:13:12, hidehiko wrote:
> > Could you use snake_case_name ?
> 
> this should be a short sentence that describes the request

Oops, I was also confused. Sorry for mis-leading, hirono-san, and thank you for
pointing this out, David.