Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(622)

Issue 2276413002: Make W3CTestExpectationsTest not subclass W3CTestExpectations. (Closed)

Created:
4 years, 3 months ago by qyearsley
Modified:
4 years, 3 months ago
Reviewers:
Dirk Pranke
CC:
blink-reviews, blink-reviews-w3ctests_chromium.org, chromium-reviews, Dirk Pranke, jsbell
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Make W3CTestExpectationsTest not subclass W3CTestExpectations. Reason: It's unnecessary and uncommon for test case classes to subclass the class that they're testing. Dre added this when he added this file, and I didn't notice this in code review at the time. This is a refactoring CL, no behavior changes. Committed: https://crrev.com/ad96d727244b9c5d67772638cf431da338ca9ed4 Cr-Commit-Position: refs/heads/master@{#414626}

Patch Set 1 #

Patch Set 2 : Make W3CTestExpectationsTest not subclass W3CTestExpectations. #

Patch Set 3 : Rebased #

Unified diffs Side-by-side diffs Delta from patch set Stats (+19 lines, -13 lines) Patch
M third_party/WebKit/Tools/Scripts/webkitpy/w3c/update_w3c_test_expectations_unittest.py View 1 2 3 chunks +19 lines, -13 lines 0 comments Download

Messages

Total messages: 16 (10 generated)
qyearsley
4 years, 3 months ago (2016-08-25 16:12:47 UTC) #2
Dirk Pranke
lgtm
4 years, 3 months ago (2016-08-25 17:18:32 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2276413002/40001
4 years, 3 months ago (2016-08-26 00:01:13 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2276413002/40001
4 years, 3 months ago (2016-08-26 01:57:18 UTC) #13
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years, 3 months ago (2016-08-26 02:03:19 UTC) #14
commit-bot: I haz the power
4 years, 3 months ago (2016-08-26 02:04:43 UTC) #16
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/ad96d727244b9c5d67772638cf431da338ca9ed4
Cr-Commit-Position: refs/heads/master@{#414626}

Powered by Google App Engine
This is Rietveld 408576698