Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 22764007: Move i18n break iterator C++ code to runtime (Closed)

Created:
7 years, 4 months ago by jochen (gone - plz use gerrit)
Modified:
7 years, 4 months ago
CC:
v8-dev
Visibility:
Public.

Description

Move i18n break iterator C++ code to runtime BUG=v8:2745 R=mstarzinger@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=16239

Patch Set 1 #

Patch Set 2 : updates #

Total comments: 2

Patch Set 3 : updates #

Patch Set 4 : updates #

Unified diffs Side-by-side diffs Delta from patch set Stats (+333 lines, -736 lines) Patch
D src/extensions/i18n/break-iterator.h View 1 chunk +0 lines, -85 lines 0 comments Download
D src/extensions/i18n/break-iterator.cc View 1 chunk +0 lines, -333 lines 0 comments Download
M src/extensions/i18n/break-iterator.js View 7 chunks +8 lines, -15 lines 0 comments Download
M src/extensions/i18n/i18n-extension.h View 1 chunk +0 lines, -3 lines 0 comments Download
M src/extensions/i18n/i18n-extension.cc View 2 chunks +0 lines, -26 lines 0 comments Download
D src/extensions/i18n/i18n-utils.h View 1 chunk +0 lines, -91 lines 0 comments Download
D src/extensions/i18n/i18n-utils.cc View 1 chunk +0 lines, -177 lines 0 comments Download
M src/i18n.h View 1 2 3 2 chunks +25 lines, -0 lines 0 comments Download
M src/i18n.cc View 1 2 3 4 chunks +132 lines, -0 lines 0 comments Download
M src/runtime.h View 1 chunk +8 lines, -0 lines 0 comments Download
M src/runtime.cc View 1 2 3 2 chunks +153 lines, -0 lines 0 comments Download
M tools/gyp/v8.gyp View 2 chunks +7 lines, -6 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
jochen (gone - plz use gerrit)
plz review
7 years, 4 months ago (2013-08-12 04:55:11 UTC) #1
dcarney
lgtm
7 years, 4 months ago (2013-08-12 08:17:37 UTC) #2
Michael Starzinger
https://codereview.chromium.org/22764007/diff/4001/tools/gyp/v8.gyp File tools/gyp/v8.gyp (right): https://codereview.chromium.org/22764007/diff/4001/tools/gyp/v8.gyp#newcode383 tools/gyp/v8.gyp:383: '../../src/i18n.cc', I couldn't find any #ifdefs for whether we ...
7 years, 4 months ago (2013-08-12 08:23:54 UTC) #3
jochen (gone - plz use gerrit)
https://codereview.chromium.org/22764007/diff/4001/tools/gyp/v8.gyp File tools/gyp/v8.gyp (right): https://codereview.chromium.org/22764007/diff/4001/tools/gyp/v8.gyp#newcode383 tools/gyp/v8.gyp:383: '../../src/i18n.cc', On 2013/08/12 08:23:54, Michael Starzinger wrote: > I ...
7 years, 4 months ago (2013-08-12 08:25:47 UTC) #4
Michael Starzinger
LGTM (although I am not familiar with the Gyp changes).
7 years, 4 months ago (2013-08-12 08:33:22 UTC) #5
jochen (gone - plz use gerrit)
7 years, 4 months ago (2013-08-20 08:46:50 UTC) #6
Message was sent while issue was closed. 
Committed patchset #4 manually as r16239.

Powered by Google App Engine
This is Rietveld 408576698