[Android] Fix ime NPE after RWH is destroyed

[Android] Fix ime NPE after RWH is destroyed

NULL check all access to RenderWidgetHost in ImeAdapterAndroid since RWH
can be null after destruction.

BUG=internal b/10143869

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=217129

[Ben Murdoch, 2013-08-12 10:36:37]

lgtm

[Ben Murdoch, 2013-08-12 10:38:08]

https://codereview.chromium.org/22764006/diff/1/content/browser/renderer_host...
File content/browser/renderer_host/ime_adapter_android.cc (right):

https://codereview.chromium.org/22764006/diff/1/content/browser/renderer_host...
content/browser/renderer_host/ime_adapter_android.cc:279: if
(!rwhva_->GetRenderWidgetHost())
nit: make a local

[benm (inactive), 2013-08-12 10:38:31]

lgtm

[benm (inactive), 2013-08-12 17:58:42]

On 2013/08/12 10:38:31, benm wrote:
> lgtm

In a similar vein, I think that we'd benefit from a null check on
mNativeImeAdapter in ImeAdapter.java's finishComposingText():
https://code.google.com/p/chromium/codesearch#chromium/src/content/public/and...

Want to do that as part of this CL too?

[boliu, 2013-08-12 17:59:46]

Oops. Forgot to reply, that's in a separate CL almost ready to land:
https://codereview.chromium.org/22882002/

[benm (inactive), 2013-08-12 18:04:55]

lgtm

[aelias_OOO_until_Jul13, 2013-08-12 18:36:51]

lgtm

[commit-bot: I haz the power, 2013-08-12 18:40:58]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/boliu@chromium.org/22764006/10001

[commit-bot: I haz the power, 2013-08-13 00:14:51]

Change committed as 217129