Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(13)

Unified Diff: appengine/swarming/elements/res/imp/tasklist/task-list-data.html

Issue 2276373002: Remove the rest of iron-ajax from bot-list-data (Closed) Base URL: https://chromium.googlesource.com/external/github.com/luci/luci-py@make-tasklist
Patch Set: Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « appengine/swarming/elements/res/imp/botlist/bot-list-data.html ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: appengine/swarming/elements/res/imp/tasklist/task-list-data.html
diff --git a/appengine/swarming/elements/res/imp/tasklist/task-list-data.html b/appengine/swarming/elements/res/imp/tasklist/task-list-data.html
index 91849b748d1b935939c3b366707e4e67f4ff9aa5..7c8f521533c8679301fe50980610cff9fdccf438 100644
--- a/appengine/swarming/elements/res/imp/tasklist/task-list-data.html
+++ b/appengine/swarming/elements/res/imp/tasklist/task-list-data.html
@@ -40,7 +40,6 @@
None.
-->
-<link rel="import" href="/res/imp/bower_components/iron-ajax/iron-ajax.html">
<link rel="import" href="/res/imp/common/common-behavior.html">
<dom-module id="task-list-data">
@@ -224,8 +223,8 @@
},
_request: function() {
- // wait until the user has logged in before requesting this.
- if (!this.auth_headers) {
+ // wait until the user has logged in and the filters have loaded before requesting this to avoid double or even triple requests.
+ if (!this.auth_headers || !this.query_params) {
return;
}
this._getJsonAsync("_list", "/_ah/api/swarming/v1/tasks/list",
« no previous file with comments | « appengine/swarming/elements/res/imp/botlist/bot-list-data.html ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698