Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(830)

Issue 2276343003: Fix CompilerDispatcherJobTest::CompileFailureToFinalize on local runs. (Closed)

Created:
4 years, 3 months ago by rmcilroy
Modified:
4 years, 3 months ago
Reviewers:
vogelheim
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Fix CompilerDispatcherJobTest::CompileFailureToFinalize on local runs. BUG= Committed: https://crrev.com/677948255b07410f21438fe6e4a81feed8aabbfb Cr-Commit-Position: refs/heads/master@{#38909}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M test/unittests/compiler-dispatcher/compiler-dispatcher-job-unittest.cc View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 12 (7 generated)
rmcilroy
Daniel does this solve your problem? PTAL, thanks.
4 years, 3 months ago (2016-08-25 13:21:37 UTC) #4
vogelheim
lgtm Applying this locally indeed fixes the issue for me. Thanks for super quick fix!
4 years, 3 months ago (2016-08-25 13:27:57 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2276343003/1
4 years, 3 months ago (2016-08-25 13:55:09 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 3 months ago (2016-08-25 13:57:29 UTC) #10
commit-bot: I haz the power
4 years, 3 months ago (2016-08-25 13:58:06 UTC) #12
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/677948255b07410f21438fe6e4a81feed8aabbfb
Cr-Commit-Position: refs/heads/master@{#38909}

Powered by Google App Engine
This is Rietveld 408576698