Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(558)

Issue 2276303003: Do not spam the debugging information (Closed)

Created:
4 years, 3 months ago by liyuqian
Modified:
4 years, 3 months ago
Reviewers:
djsollen
CC:
reviews_skia.org, egdaniel
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Do not spam the debugging information Currently, whenever there's a frame being rendered, we log such an invalidation event. This is very spammy for animations or frame rates test. BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2276303003 Committed: https://skia.googlesource.com/skia/+/1c9f55b468e14eb3e6b1bb8cb740818d8f036859

Patch Set 1 #

Total comments: 1

Patch Set 2 : Do not spam the debugging information #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -1 line) Patch
M tools/viewer/sk_app/android/surface_glue_android.cpp View 1 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 10 (6 generated)
liyuqian
Hi Derek, please let me know if commenting out the SkDebugf line is the best ...
4 years, 3 months ago (2016-08-25 17:49:30 UTC) #4
djsollen
lgtm with nit https://codereview.chromium.org/2276303003/diff/1/tools/viewer/sk_app/android/surface_glue_android.cpp File tools/viewer/sk_app/android/surface_glue_android.cpp (right): https://codereview.chromium.org/2276303003/diff/1/tools/viewer/sk_app/android/surface_glue_android.cpp#newcode94 tools/viewer/sk_app/android/surface_glue_android.cpp:94: // SkDebugf("message_callback %d", message.fType); remove the ...
4 years, 3 months ago (2016-08-25 19:10:37 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2276303003/20001
4 years, 3 months ago (2016-08-25 19:48:08 UTC) #8
commit-bot: I haz the power
4 years, 3 months ago (2016-08-25 20:14:58 UTC) #10
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://skia.googlesource.com/skia/+/1c9f55b468e14eb3e6b1bb8cb740818d8f036859

Powered by Google App Engine
This is Rietveld 408576698