Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(741)

Issue 2276273002: [turbofan] Disable LoadElimination completely for asm.js. (Closed)

Created:
4 years, 4 months ago by Benedikt Meurer
Modified:
4 years, 4 months ago
Reviewers:
Jarin
CC:
v8-reviews_googlegroups.com
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[turbofan] Disable LoadElimination completely for asm.js. There's no point in running the LoadElimination on asm.js functions and it would take serious amount of effort to actually make it correct for the deprecated parts of the pipeline. R=jarin@chromium.org BUG=v8:5308 Committed: https://crrev.com/b471d4ab5cf48c754d4a3c616e932828a48ab4f8 Cr-Commit-Position: refs/heads/master@{#38884}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+27 lines, -1 line) Patch
M src/compiler/pipeline.cc View 1 chunk +1 line, -1 line 0 comments Download
A test/mjsunit/asm/load-elimination.js View 1 chunk +26 lines, -0 lines 0 comments Download

Messages

Total messages: 11 (5 generated)
Benedikt Meurer
4 years, 4 months ago (2016-08-25 05:42:02 UTC) #1
Benedikt Meurer
Hey Jaro, There's no point in trying to make the LoadElimination work for the deprecated ...
4 years, 4 months ago (2016-08-25 05:45:54 UTC) #4
Jarin
lgtm, but I would be more comfortable if we kept track of element sizes or ...
4 years, 4 months ago (2016-08-25 05:55:13 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2276273002/1
4 years, 4 months ago (2016-08-25 05:55:54 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 4 months ago (2016-08-25 06:14:45 UTC) #9
commit-bot: I haz the power
4 years, 4 months ago (2016-08-25 06:15:05 UTC) #11
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/b471d4ab5cf48c754d4a3c616e932828a48ab4f8
Cr-Commit-Position: refs/heads/master@{#38884}

Powered by Google App Engine
This is Rietveld 408576698