systrace/profile_chrome/flags.py - Issue 2276263003: Pass in custom options to Systrace agents

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: systrace/profile_chrome/flags.py

Issue 2276263003: Pass in custom options to Systrace agents (Closed) Base URL: https://chromium.googlesource.com/external/github.com/catapult-project/catapult.git@master

Patch Set: Set categories based on target devices and revised comments Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« systrace/profile_chrome/chrome_startup_tracing_agent.py ('K') | « systrace/profile_chrome/ddms_tracing_agent_unittest.py ('k') | systrace/profile_chrome/main.py » ('j') | systrace/profile_chrome/main.py » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: systrace/profile_chrome/flags.py

diff --git a/systrace/profile_chrome/flags.py b/systrace/profile_chrome/flags.py

index 173735358212af3df77fe30e297830ca454f837f..e0c3019e6f847da4782fcd4177562716deca11b2 100644

--- a/systrace/profile_chrome/flags.py

+++ b/systrace/profile_chrome/flags.py

@@ -4,19 +4,6 @@

import optparse

-def AtraceOptions(parser):

- atrace_opts = optparse.OptionGroup(parser, 'Systrace tracing options')

- atrace_opts.add_option('-s', '--systrace', help='Capture a systrace with '

- 'the chosen comma-delimited systrace categories. You'

- ' can also capture a combined Chrome + systrace by '

- 'enabling both types of categories. Use "list" to '

- 'see the available categories. Systrace is disabled'

- ' by default. Note that in this case, Systrace is '

- 'synonymous with Atrace.',

- metavar='ATRACE_CATEGORIES',

- dest='atrace_categories', default='')

- return atrace_opts

def OutputOptions(parser):

output_options = optparse.OptionGroup(parser, 'Output options')