systrace/profile_chrome/perf_tracing_agent_unittest.py - Issue 2276263003: Pass in custom options to Systrace agents

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: systrace/profile_chrome/perf_tracing_agent_unittest.py

Issue 2276263003: Pass in custom options to Systrace agents (Closed) Base URL: https://chromium.googlesource.com/external/github.com/catapult-project/catapult.git@master

Patch Set: Rebase Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: systrace/profile_chrome/perf_tracing_agent_unittest.py

diff --git a/systrace/profile_chrome/perf_tracing_agent_unittest.py b/systrace/profile_chrome/perf_tracing_agent_unittest.py

index 1367e9b759f3aacb0eb1fbdc56cf6eb7f9a3bb75..cd90b3691744ee7cd8982fc8279fe830d689f252 100644

--- a/systrace/profile_chrome/perf_tracing_agent_unittest.py

+++ b/systrace/profile_chrome/perf_tracing_agent_unittest.py

@@ -21,12 +21,11 @@ class PerfProfilerAgentTest(agents_unittest.BaseAgentTest):

if not perf_tracing_agent.PerfProfilerAgent.IsSupported():

return

ui.EnableTestMode()

- categories = ['cycles']

- agent = perf_tracing_agent.PerfProfilerAgent(self.device,

- categories)

+ categories = 'cycles'

+ agent = perf_tracing_agent.PerfProfilerAgent(self.device)

try:

- agent.StartAgentTracing(None, None)

+ agent.StartAgentTracing(perf_tracing_agent.PerfConfig(categories))

finally:

agent.StopAgentTracing()

« no previous file with comments | « systrace/profile_chrome/perf_tracing_agent.py ('k') | systrace/profile_chrome/profiler.py » ('j') | no next file with comments »