systrace/profile_chrome/atrace_tracing_agent_unittest.py - Issue 2276263003: Pass in custom options to Systrace agents

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: systrace/profile_chrome/atrace_tracing_agent_unittest.py

Issue 2276263003: Pass in custom options to Systrace agents (Closed) Base URL: https://chromium.googlesource.com/external/github.com/catapult-project/catapult.git@master

Patch Set: Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« systrace/profile_chrome/atrace_tracing_agent.py ('K') | « systrace/profile_chrome/atrace_tracing_agent.py ('k') | systrace/profile_chrome/chrome_startup_tracing_agent.py » ('j') | systrace/profile_chrome/profiler.py » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: systrace/profile_chrome/atrace_tracing_agent_unittest.py

diff --git a/systrace/profile_chrome/atrace_tracing_agent_unittest.py b/systrace/profile_chrome/atrace_tracing_agent_unittest.py

index 8460e9b491bd8b63d4cab7a82a79d3b3bec9c2d7..8ef19d7b38e853fd9b200cd3b2fb4eb5f5da3a6f 100644

--- a/systrace/profile_chrome/atrace_tracing_agent_unittest.py

+++ b/systrace/profile_chrome/atrace_tracing_agent_unittest.py

@@ -14,14 +14,12 @@ class AtraceAgentTest(agents_unittest.BaseAgentTest):

assert 'gfx' in ' '.join(categories)

def testTracing(self):

- categories = ['gfx', 'input', 'view']

Sami 2016/08/26 15:53:43 Can we keep using these categories? I'm not sure w

washingtonp 2016/08/26 18:50:54 Done. Updated other profile_chrome unit tests as w

ring_buffer = False

agent = atrace_tracing_agent.AtraceAgent(self.device,

- categories,

ring_buffer)

try:

- agent.StartAgentTracing(None, None)

+ agent.StartAgentTracing(atrace_tracing_agent.AtraceConfig(None))

finally:

agent.StopAgentTracing()

result = agent.GetResults()