Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(411)

Unified Diff: telemetry/telemetry/internal/platform/tracing_agent/atrace_tracing_agent.py

Issue 2276263003: Pass in custom options to Systrace agents (Closed) Base URL: https://chromium.googlesource.com/external/github.com/catapult-project/catapult.git@master
Patch Set: Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: telemetry/telemetry/internal/platform/tracing_agent/atrace_tracing_agent.py
diff --git a/telemetry/telemetry/internal/platform/tracing_agent/atrace_tracing_agent.py b/telemetry/telemetry/internal/platform/tracing_agent/atrace_tracing_agent.py
index 5a939dfa15b247243fb3f91d4739caef894816a7..ed36697994a75fdd8825f469d0b3b758000d44bf 100644
--- a/telemetry/telemetry/internal/platform/tracing_agent/atrace_tracing_agent.py
+++ b/telemetry/telemetry/internal/platform/tracing_agent/atrace_tracing_agent.py
@@ -18,7 +18,7 @@ class AtraceOpts(object):
to do so.
'''
- def __init__(self, serial_number, app_name):
+ def __init__(self, serial_number, app_name, categories):
self.compress_trace_data = True
self.trace_time = None
self.trace_buf_size = None
@@ -29,6 +29,7 @@ class AtraceOpts(object):
self.fix_tgids = True
self.fix_circular = True
self.device_serial_number = serial_number
+ self.atrace_categories = categories
class AtraceTracingAgent(tracing_agent.TracingAgent):
def __init__(self, platform_backend):
@@ -36,7 +37,7 @@ class AtraceTracingAgent(tracing_agent.TracingAgent):
self._device = platform_backend.device
self._categories = None
self._atrace_agent = atrace_agent.AtraceAgent()
- self._options = None
+ self._config = None
@classmethod
def IsSupported(cls, platform_backend):
@@ -46,10 +47,10 @@ class AtraceTracingAgent(tracing_agent.TracingAgent):
def StartAgentTracing(self, config, timeout):
if not config.enable_atrace_trace:
return False
- self._categories = config.atrace_config.categories
- self._options = AtraceOpts(str(self._device), config.atrace_config.app_name)
- return self._atrace_agent.StartAgentTracing(
- self._options, self._categories, timeout)
+ self._config = AtraceOpts(str(self._device),
+ config.atrace_config.app_name,
+ config.atrace_config.categories)
+ return self._atrace_agent.StartAgentTracing(self._config, timeout)
def StopAgentTracing(self):
self._atrace_agent.StopAgentTracing()
« systrace/systrace/tracing_agents/__init__.py ('K') | « systrace/systrace/tracing_controller.py ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698