Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(181)

Unified Diff: systrace/profile_chrome/profiler_unittest.py

Issue 2276263003: Pass in custom options to Systrace agents (Closed) Base URL: https://chromium.googlesource.com/external/github.com/catapult-project/catapult.git@master
Patch Set: Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: systrace/profile_chrome/profiler_unittest.py
diff --git a/systrace/profile_chrome/profiler_unittest.py b/systrace/profile_chrome/profiler_unittest.py
index 99ca6111583520c0d61bb71c962b174e54477898..cffcf5ff3254ab76cf2924ed49342f5c3fdea655 100644
--- a/systrace/profile_chrome/profiler_unittest.py
+++ b/systrace/profile_chrome/profiler_unittest.py
@@ -17,13 +17,11 @@ class FakeAgent(object):
self.contents = contents
self.stopped = False
self.filename = None
- self.options = None
- self.categories = None
+ self.config = None
self.timeout = None
- def StartAgentTracing(self, options, categories, timeout=None):
- self.options = options
- self.categories = categories
+ def StartAgentTracing(self, config, timeout=None):
+ self.config = config
self.timeout = timeout
# pylint: disable=unused-argument
@@ -60,7 +58,7 @@ class ProfilerTest(unittest.TestCase):
def testCaptureBasicProfile(self):
agent = FakeAgent()
- result = profiler.CaptureProfile([agent], 1)
+ result = profiler.CaptureProfile(None, [agent], 1)
try:
self.assertTrue(agent.stopped)
@@ -72,7 +70,7 @@ class ProfilerTest(unittest.TestCase):
def testCaptureJsonProfile(self):
agent = FakeAgent()
- result = profiler.CaptureProfile([agent], 1, write_json=True)
+ result = profiler.CaptureProfile(None, [agent], 1, write_json=True)
try:
self.assertFalse(result.endswith('.html'))
@@ -84,7 +82,7 @@ class ProfilerTest(unittest.TestCase):
def testCaptureMultipleProfiles(self):
agents = [FakeAgent('c1'), FakeAgent('c2')]
- result = profiler.CaptureProfile(agents, 1, write_json=True)
+ result = profiler.CaptureProfile(None, agents, 1, write_json=True)
try:
self.assertTrue(result.endswith('.zip'))

Powered by Google App Engine
This is Rietveld 408576698