Pass in custom options to Systrace agents

systrace/systrace/tracing_agents/__init__.py

 #!/usr/bin/env python
 
 # Copyright 2016 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
 '''Tracing agent interface for systrace.
 
 This class represents an agent that captures traces from a particular
 tool (e.g. atrace, ftrace.)
 '''
 
 # Timeout interval constants.
 
 START_STOP_TIMEOUT = 10.0
 GET_RESULTS_TIMEOUT = 30.0
 
 
+class TracingConfig(object):
+  '''Store the tracing configuration options for all Systrace agents. If there
+  are ever any options that are to be shared between all of the agents, those
+  options should go here.
+  '''
+  def __init__(self):
+    pass
+
 class TracingAgent(object):
   def __init__(self):
     pass
 
-  def StartAgentTracing(self, options, categories, timeout=None):
+  def StartAgentTracing(self, config, timeout=None):
     '''Starts running the trace for this agent. Stops with timeout if
     not completed within timeout interval.
 
     Args:
-        options: Tracing options.
-        categories: Categories of trace events to record.
+        config: TracingOptions subclass containing agent-specific options

[Sami, 2016/08/26 15:53:43]

s/TracingOptions/TracingConfig/?

[washingtonp, 2016/08/26 18:50:54]

Done.

+                and categories.
         timeout: Timeout interval in seconds.
 
     Returns:
         Boolean value indicating whether or not the trace started successfully.
     '''
     pass
 
   def StopAgentTracing(self, timeout=None):
     '''Stops running the trace for this agent and returns immediately.
     Stops with timeout if not completed within timeout interval.
@@ skipping 33 matching lines @@
     StopAgentTracing is done. This function blocks until the result
     is collected (note; this may take several seconds). Stops with timeout
     if not completed within self._options.collection_timeout seconds.
 
     Args:
         timeout: Timeout interval in seconds.
     Returns:
         Completed trace for this agent.
     '''
     pass