Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1250)

Unified Diff: src/factory.h

Issue 227623002: Handlify ten allocator functions from the Heap. (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: Created 6 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | src/factory.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/factory.h
diff --git a/src/factory.h b/src/factory.h
index bd33ac0c640fdc07b6ad1c0205fdb70f1206fbc8..c1b7ba72515296913a3dad735ca6516b91476502 100644
--- a/src/factory.h
+++ b/src/factory.h
@@ -14,11 +14,6 @@ namespace internal {
class Factory V8_FINAL {
public:
- // Allocate a new boxed value.
- Handle<Box> NewBox(
- Handle<Object> value,
- PretenureFlag pretenure = NOT_TENURED);
-
// Allocates a fixed array initialized with undefined values.
Handle<FixedArray> NewFixedArray(
int size,
@@ -71,6 +66,9 @@ class Factory V8_FINAL {
int deopt_entry_count,
PretenureFlag pretenure);
+ // Create a new boxed value.
+ Handle<Box> NewBox(Handle<Object> value);
+
// Create a pre-tenured empty AccessorPair.
Handle<AccessorPair> NewAccessorPair();
@@ -331,10 +329,13 @@ class Factory V8_FINAL {
// JS arrays are pretenured when allocated by the parser.
+ // Create a JSArray with no elements.
Handle<JSArray> NewJSArray(
ElementsKind elements_kind,
PretenureFlag pretenure = NOT_TENURED);
+ // Create a JSArray with a specified length and elements initialized
+ // according to the specified mode.
Handle<JSArray> NewJSArray(
ElementsKind elements_kind,
int length,
@@ -353,7 +354,7 @@ class Factory V8_FINAL {
INITIALIZE_ARRAY_ELEMENTS_WITH_HOLE, pretenure);
}
- // Allocate a JSArray with no elements
+ // Create a JSArray with the given elements.
Handle<JSArray> NewJSArrayWithElements(
Handle<FixedArrayBase> elements,
ElementsKind elements_kind,
« no previous file with comments | « no previous file | src/factory.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698