Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(106)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2276203002: Fixed template in HeapSnapshotClassReferences implementation (Closed)

Created:
4 years, 4 months ago by cbernaschina
Modified:
4 years, 4 months ago
Reviewers:
Cutch
CC:
reviews_dartlang.org, turnidge, rmacnak, Cutch, vm-dev_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Fixed template in HeapSnapshotClassReferences implementation Fixes=https://github.com/dart-lang/sdk/issues/27144 TBR=johnmccutchan@google.com Committed: https://github.com/dart-lang/sdk/commit/97da42bd45aa10f562bb999922623a484a1d1ac8

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -2 lines) Patch
M runtime/observatory/lib/src/heap_snapshot/heap_snapshot.dart View 2 chunks +6 lines, -2 lines 2 comments Download

Messages

Total messages: 5 (1 generated)
cbernaschina
4 years, 4 months ago (2016-08-24 22:57:16 UTC) #1
cbernaschina
Committed patchset #1 (id:1) manually as 97da42bd45aa10f562bb999922623a484a1d1ac8 (presubmit successful).
4 years, 4 months ago (2016-08-24 22:57:30 UTC) #3
Cutch
DBC https://codereview.chromium.org/2276203002/diff/1/runtime/observatory/lib/src/heap_snapshot/heap_snapshot.dart File runtime/observatory/lib/src/heap_snapshot/heap_snapshot.dart (right): https://codereview.chromium.org/2276203002/diff/1/runtime/observatory/lib/src/heap_snapshot/heap_snapshot.dart#newcode199 runtime/observatory/lib/src/heap_snapshot/heap_snapshot.dart:199: return new HeapSnapshotClassInbound(this, edge); Should this be HeapSNapshotClassOutbound?
4 years, 4 months ago (2016-08-24 23:00:46 UTC) #4
cbernaschina
4 years, 4 months ago (2016-08-24 23:04:36 UTC) #5
Message was sent while issue was closed. 
https://codereview.chromium.org/2276203002/diff/1/runtime/observatory/lib/src...
File runtime/observatory/lib/src/heap_snapshot/heap_snapshot.dart (right):

https://codereview.chromium.org/2276203002/diff/1/runtime/observatory/lib/src...
runtime/observatory/lib/src/heap_snapshot/heap_snapshot.dart:199: return new
HeapSnapshotClassInbound(this, edge);
On 2016/08/24 23:00:46, Cutch wrote:
> Should this be HeapSNapshotClassOutbound?

see https://codereview.chromium.org/2277073002/

Powered by Google App Engine
This is Rietveld 408576698