mac: Don't lose pixels when copying a retina image from the clipboard.

mac: Don't lose pixels when copying a retina image from the clipboard.

The image is converted into an SkBitmap, which has no concept of retina-ness. In
the previous behavior, Chrome would maintain the image size but lose half the
pixels. In the new behavior, Chrome keeps all the pixels and doubles the size of
the SkBitmap.

BUG=355477
Committed: https://crrev.com/7917e6ae37f5f838299aaaa65f785a0e657bc5bd
Cr-Commit-Position: refs/heads/master@{#415171}

[erikchen, 2016-08-24 22:09:23]

erikchen@chromium.org changed reviewers:
+ avi@chromium.org

[erikchen, 2016-08-24 22:09:24]

avi: Please review.

[erikchen, 2016-08-24 22:09:29]

The CQ bit was checked by erikchen@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-08-24 22:10:33]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Avi (use Gerrit), 2016-08-25 18:57:25]

https://codereview.chromium.org/2276183002/diff/20001/ui/base/clipboard/clipb...
File ui/base/clipboard/clipboard_mac.mm (right):

https://codereview.chromium.org/2276183002/diff/20001/ui/base/clipboard/clipb...
ui/base/clipboard/clipboard_mac.mm:329: NSBitmapImageRep* rep = [[image
representations] objectAtIndex:0];
NSImageRep* rep =
not
NSBitmapImageRep* rep =

You don't know what type of rep it is, and it doesn't matter for this call.

[erikchen, 2016-08-26 17:55:33]

avi: PTAL

https://codereview.chromium.org/2276183002/diff/20001/ui/base/clipboard/clipb...
File ui/base/clipboard/clipboard_mac.mm (right):

https://codereview.chromium.org/2276183002/diff/20001/ui/base/clipboard/clipb...
ui/base/clipboard/clipboard_mac.mm:329: NSBitmapImageRep* rep = [[image
representations] objectAtIndex:0];
On 2016/08/25 18:57:25, Avi wrote:
> NSImageRep* rep =
> not
> NSBitmapImageRep* rep =
> 
> You don't know what type of rep it is, and it doesn't matter for this call.

Done.

[erikchen, 2016-08-26 17:55:39]

The CQ bit was checked by erikchen@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-08-26 17:56:05]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-26 18:18:56]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-26 18:18:57]

Dry run: Try jobs failed on following builders:
  mac_chromium_compile_dbg_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_comp...)

[Avi (use Gerrit), 2016-08-26 19:25:46]

lgtm

[erikchen, 2016-08-29 17:15:12]

The CQ bit was checked by erikchen@chromium.org

[erikchen, 2016-08-29 17:15:12]

The patchset sent to the CQ was uploaded after l-g-t-m from avi@chromium.org
Link to the patchset: https://codereview.chromium.org/2276183002/#ps60001
(title: "Rebase.")

[commit-bot: I haz the power, 2016-08-29 17:27:30]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-30 05:41:37]

Committed patchset #4 (id:60001)

[commit-bot: I haz the power, 2016-08-30 05:43:13]

Description was changed from

==========
mac: Don't lose pixels when copying a retina image from the clipboard.

The image is converted into an SkBitmap, which has no concept of retina-ness. In
the previous behavior, Chrome would maintain the image size but lose half the
pixels. In the new behavior, Chrome keeps all the pixels and doubles the size of
the SkBitmap.

BUG=355477
==========

to

==========
mac: Don't lose pixels when copying a retina image from the clipboard.

The image is converted into an SkBitmap, which has no concept of retina-ness. In
the previous behavior, Chrome would maintain the image size but lose half the
pixels. In the new behavior, Chrome keeps all the pixels and doubles the size of
the SkBitmap.

BUG=355477

Committed: https://crrev.com/7917e6ae37f5f838299aaaa65f785a0e657bc5bd
Cr-Commit-Position: refs/heads/master@{#415171}
==========

[commit-bot: I haz the power, 2016-08-30 05:43:14]

Patchset 4 (id:??) landed as
https://crrev.com/7917e6ae37f5f838299aaaa65f785a0e657bc5bd
Cr-Commit-Position: refs/heads/master@{#415171}