Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(693)

Issue 2276133002: mojo_runner: Use prefer_own_symbols when loading DSOs (Closed)

Created:
4 years, 4 months ago by Ken Rockot(use gerrit already)
Modified:
4 years, 3 months ago
Reviewers:
sky
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@native-library-local-symbols
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

mojo_runner: Use prefer_own_symbols when loading DSOs Uses the new prefer_own_symbols option on LoadNativeLibrary to ensure that loaded service libraries always prefer local symbols over global ones. This fixes asymmetry between tc_malloc/free inside DSO code which has been breaking ash+skia in non-component builds. BUG=594674

Patch Set 1 #

Patch Set 2 : rebase #

Patch Set 3 : rebase #

Patch Set 4 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -1 line) Patch
M services/shell/runner/host/native_application_support.cc View 1 chunk +5 lines, -1 line 0 comments Download

Depends on Patchset:

Messages

Total messages: 20 (16 generated)
Ken Rockot(use gerrit already)
4 years, 3 months ago (2016-08-25 23:22:26 UTC) #13
Ken Rockot(use gerrit already)
Surprise! This breaks a bunch of other tests now, with similar tcmalloc errors. :|
4 years, 3 months ago (2016-08-26 02:06:12 UTC) #18
Ken Rockot(use gerrit already)
(I bet we need RTLD_GLOBAL even though I thought we wouldn't)
4 years, 3 months ago (2016-08-26 02:07:16 UTC) #19
sky
4 years, 3 months ago (2016-08-26 03:17:28 UTC) #20
LGTM

Powered by Google App Engine
This is Rietveld 408576698