Fix CaptureMjpeg test may fail on devices that cannot capture MJPEG.

Fix CaptureMjpeg test fails on devices that cannot capture MJPEG.

BUG=335764
TEST=build and run the test on snow

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=262966

[Ami GONE FROM CHROMIUM, 2014-04-07 17:14:17]

https://codereview.chromium.org/227613005/diff/10001/media/video/capture/vide...
File media/video/capture/video_capture_device_unittest.cc (right):

https://codereview.chromium.org/227613005/diff/10001/media/video/capture/vide...
media/video/capture/video_capture_device_unittest.cc:131:
scoped_ptr<VideoCaptureDevice::Name> GetRquestedPixelFormatDeviceName(
typo: GetRquestedPixelFormatDeviceName

https://codereview.chromium.org/227613005/diff/10001/media/video/capture/vide...
media/video/capture/video_capture_device_unittest.cc:131:
scoped_ptr<VideoCaptureDevice::Name> GetRquestedPixelFormatDeviceName(
This function's name is a bit convoluted, and "requested" doesn't seem to be
adding value.  WDYT of GetFirstDeviceNameSupportingPixelFormat() and
"pixel_format" for the param?

https://codereview.chromium.org/227613005/diff/10001/media/video/capture/vide...
media/video/capture/video_capture_device_unittest.cc:142:
VideoCaptureDevice::GetDeviceSupportedFormats(*names_iterator,
This doesn't specify that it clears its output argument, so you should move
l.138 to l.142 (inside the loop) or else clear it explicitly).

https://codereview.chromium.org/227613005/diff/10001/media/video/capture/vide...
media/video/capture/video_capture_device_unittest.cc:153: DVLOG(1) << "No camera
can capture the requested pixel format.";
DVLOG(1) << "No camera can capture " << requested_pixel_format;

[yuli, 2014-04-08 07:42:53]

https://codereview.chromium.org/227613005/diff/10001/media/video/capture/vide...
File media/video/capture/video_capture_device_unittest.cc (right):

https://codereview.chromium.org/227613005/diff/10001/media/video/capture/vide...
media/video/capture/video_capture_device_unittest.cc:131:
scoped_ptr<VideoCaptureDevice::Name> GetRquestedPixelFormatDeviceName(
On 2014/04/07 17:14:17, Ami Fischman wrote:
> This function's name is a bit convoluted, and "requested" doesn't seem to be
> adding value.  WDYT of GetFirstDeviceNameSupportingPixelFormat() and
> "pixel_format" for the param?

Done.

https://codereview.chromium.org/227613005/diff/10001/media/video/capture/vide...
media/video/capture/video_capture_device_unittest.cc:142:
VideoCaptureDevice::GetDeviceSupportedFormats(*names_iterator,
On 2014/04/07 17:14:17, Ami Fischman wrote:
> This doesn't specify that it clears its output argument, so you should move
> l.138 to l.142 (inside the loop) or else clear it explicitly).

Done.

https://codereview.chromium.org/227613005/diff/10001/media/video/capture/vide...
media/video/capture/video_capture_device_unittest.cc:153: DVLOG(1) << "No camera
can capture the requested pixel format.";
On 2014/04/07 17:14:17, Ami Fischman wrote:
> DVLOG(1) << "No camera can capture " << requested_pixel_format;

Done.

[Ami GONE FROM CHROMIUM, 2014-04-08 16:39:47]

LGTM with optional nits.

https://codereview.chromium.org/227613005/diff/30001/media/video/capture/vide...
File media/video/capture/video_capture_device_unittest.cc (right):

https://codereview.chromium.org/227613005/diff/30001/media/video/capture/vide...
media/video/capture/video_capture_device_unittest.cc:363: if (name.get() ==
NULL) {
nit: FYI
if (name.get() == NULL) {
is equiv to the shorter and more readable IMO:
if (!name) {

https://codereview.chromium.org/227613005/diff/30001/media/video/capture/vide...
media/video/capture/video_capture_device_unittest.cc:394: ASSERT_TRUE(name.get()
== NULL);
ditto ASSERT_FALSE(name);

[yuli, 2014-04-09 05:08:28]

https://codereview.chromium.org/227613005/diff/30001/media/video/capture/vide...
File media/video/capture/video_capture_device_unittest.cc (right):

https://codereview.chromium.org/227613005/diff/30001/media/video/capture/vide...
media/video/capture/video_capture_device_unittest.cc:363: if (name.get() ==
NULL) {
On 2014/04/08 16:39:47, Ami Fischman wrote:
> nit: FYI
> if (name.get() == NULL) {
> is equiv to the shorter and more readable IMO:
> if (!name) {

Done.

https://codereview.chromium.org/227613005/diff/30001/media/video/capture/vide...
media/video/capture/video_capture_device_unittest.cc:394: ASSERT_TRUE(name.get()
== NULL);
On 2014/04/08 16:39:47, Ami Fischman wrote:
> ditto ASSERT_FALSE(name);

Done.

[yuli, 2014-04-10 05:26:29]

The CQ bit was checked by yuli@chromium.org

[commit-bot: I haz the power, 2014-04-10 05:26:39]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/yuli@chromium.org/227613005/50001

[commit-bot: I haz the power, 2014-04-10 13:34:44]

Change committed as 262966