Add data usage tracking for NTP tiles

Add data usage tracking for NTP tiles

BUG=527304
Committed: https://crrev.com/25843d275d79871cbf67e7870b9e02e2ca8ef563
Cr-Commit-Position: refs/heads/master@{#421146}

[Raj, 2016-08-24 19:03:24]

rajendrant@chromium.org changed reviewers:
+ sfiera@chromium.org

[Raj, 2016-08-24 19:03:24]

ptal

[sfiera, 2016-08-25 05:39:46]

Thanks for sending this our way!

https://codereview.chromium.org/2276113002/diff/1/components/ntp_tiles/popula...
File components/ntp_tiles/popular_sites.cc (right):

https://codereview.chromium.org/2276113002/diff/1/components/ntp_tiles/popula...
components/ntp_tiles/popular_sites.cc:283: fetcher_.get(),
data_use_measurement::DataUseUserData::NTP_SNIPPETS);
This doesn't seem like the right enum value. NTP_SNIPPETS is for
components/ntp_snippets, which has a different data usage pattern from here
(steady-state, vs. only new-ish users here).

Popular sites also downloads site icons, so a TODO to count that usage too would
be good. (TODO(sfiera) is fine)

[Raj, 2016-09-22 19:12:02]

rajendrant@chromium.org changed reviewers:
+ sclittle@chromium.org

[Raj, 2016-09-22 19:12:03]

ptal

https://codereview.chromium.org/2276113002/diff/1/components/ntp_tiles/popula...
File components/ntp_tiles/popular_sites.cc (right):

https://codereview.chromium.org/2276113002/diff/1/components/ntp_tiles/popula...
components/ntp_tiles/popular_sites.cc:283: fetcher_.get(),
data_use_measurement::DataUseUserData::NTP_SNIPPETS);
On 2016/08/25 05:39:46, sfiera wrote:
> This doesn't seem like the right enum value. NTP_SNIPPETS is for
> components/ntp_snippets, which has a different data usage pattern from here
> (steady-state, vs. only new-ish users here).
> 
> Popular sites also downloads site icons, so a TODO to count that usage too
would
> be good. (TODO(sfiera) is fine)

Done.

[Marc Treib, 2016-09-22 19:15:17]

treib@chromium.org changed reviewers:
+ treib@chromium.org

[Marc Treib, 2016-09-22 19:15:17]

https://codereview.chromium.org/2276113002/diff/20001/components/data_use_mea...
File components/data_use_measurement/core/data_use_user_data.cc (right):

https://codereview.chromium.org/2276113002/diff/20001/components/data_use_mea...
components/data_use_measurement/core/data_use_user_data.cc:62: return NTP_TILES;
Drive-by: This should probably be "NTPTiles" (i.e. a string)?

[sclittle, 2016-09-22 20:05:23]

components/data_use_measurement/* + added dep on this component LGTM

[Raj, 2016-09-22 20:41:31]

ptal

https://codereview.chromium.org/2276113002/diff/20001/components/data_use_mea...
File components/data_use_measurement/core/data_use_user_data.cc (right):

https://codereview.chromium.org/2276113002/diff/20001/components/data_use_mea...
components/data_use_measurement/core/data_use_user_data.cc:62: return NTP_TILES;
On 2016/09/22 19:15:17, Marc Treib wrote:
> Drive-by: This should probably be "NTPTiles" (i.e. a string)?

Yes. Fixed it.

[sfiera, 2016-09-23 08:15:02]

LGTM with one change:

https://codereview.chromium.org/2276113002/diff/40001/components/ntp_tiles/po...
File components/ntp_tiles/popular_sites.cc (right):

https://codereview.chromium.org/2276113002/diff/40001/components/ntp_tiles/po...
components/ntp_tiles/popular_sites.cc:284: fetcher_.get(),
data_use_measurement::DataUseUserData::NTP_SNIPPETS);
Needs to be NTP_TILES here.

[Raj, 2016-09-23 22:42:27]

rajendrant@chromium.org changed reviewers:
+ rkaplow@chromium.org

[Raj, 2016-09-23 22:42:28]

rkaplow: ptal histograms.xml

[rkaplow, 2016-09-26 14:02:59]

lgtm

[Raj, 2016-09-26 17:24:27]

The CQ bit was checked by rajendrant@chromium.org

[Raj, 2016-09-26 17:24:27]

The patchset sent to the CQ was uploaded after l-g-t-m from sfiera@chromium.org,
sclittle@chromium.org
Link to the patchset: https://codereview.chromium.org/2276113002/#ps60001
(title: "minor fix")

[commit-bot: I haz the power, 2016-09-26 17:25:16]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-26 17:34:07]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-26 17:34:08]

Try jobs failed on following builders:
  cast_shell_linux on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/cast_shell_linu...)
  mac_chromium_compile_dbg_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_comp...)

[Raj, 2016-09-26 22:40:48]

The CQ bit was checked by rajendrant@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-09-26 22:41:15]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-26 23:53:24]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-26 23:53:25]

Dry run: Try jobs failed on following builders:
  linux_chromium_chromeos_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[Raj, 2016-09-26 23:59:33]

The CQ bit was checked by rajendrant@chromium.org

[Raj, 2016-09-26 23:59:34]

The patchset sent to the CQ was uploaded after l-g-t-m from
rkaplow@chromium.org, sfiera@chromium.org, sclittle@chromium.org
Link to the patchset: https://codereview.chromium.org/2276113002/#ps80001
(title: "rebased")

[commit-bot: I haz the power, 2016-09-27 00:00:03]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-27 01:37:09]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-27 01:37:10]

Try jobs failed on following builders:
  linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/linux_androi...)

[Raj, 2016-09-27 01:48:21]

The CQ bit was checked by rajendrant@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-09-27 01:48:49]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-27 03:33:03]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-27 03:33:04]

Dry run: Try jobs failed on following builders:
  win_chromium_x64_rel_ng on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_x64_...)

[Raj, 2016-09-27 04:24:47]

Patchset #6 (id:100001) has been deleted

[Raj, 2016-09-27 04:24:52]

Patchset #5 (id:80001) has been deleted

[Raj, 2016-09-27 04:26:08]

The CQ bit was checked by rajendrant@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-09-27 04:26:30]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-27 05:47:33]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-27 05:47:34]

Dry run: Try jobs failed on following builders:
  linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/linux_androi...)

[Raj, 2016-09-27 06:49:19]

The CQ bit was checked by rajendrant@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-09-27 06:49:26]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Raj, 2016-09-27 06:49:42]

Patchset #5 (id:120001) has been deleted

[Raj, 2016-09-27 07:31:01]

The CQ bit was unchecked by rajendrant@chromium.org

[Raj, 2016-09-27 07:31:09]

The CQ bit was checked by rajendrant@chromium.org

[Raj, 2016-09-27 07:31:10]

The patchset sent to the CQ was uploaded after l-g-t-m from
rkaplow@chromium.org, sfiera@chromium.org, sclittle@chromium.org
Link to the patchset: https://codereview.chromium.org/2276113002/#ps140001
(title: "rebased")

[commit-bot: I haz the power, 2016-09-27 07:31:31]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-27 08:13:50]

Committed patchset #5 (id:140001)

[commit-bot: I haz the power, 2016-09-27 08:15:39]

Description was changed from

==========
Add data usage tracking for NTP tiles

BUG=527304
==========

to

==========
Add data usage tracking for NTP tiles

BUG=527304

Committed: https://crrev.com/25843d275d79871cbf67e7870b9e02e2ca8ef563
Cr-Commit-Position: refs/heads/master@{#421146}
==========

[commit-bot: I haz the power, 2016-09-27 08:15:40]

Patchset 5 (id:??) landed as
https://crrev.com/25843d275d79871cbf67e7870b9e02e2ca8ef563
Cr-Commit-Position: refs/heads/master@{#421146}