Issue 22761002: Eliminate NetworkLoginObserver

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 22761002: Eliminate NetworkLoginObserver (Closed)

Created:
7 years, 4 months ago by stevenjb

Modified:
7 years, 4 months ago

Reviewers:
gauravsh

CC:
chromium-reviews, nkostylev+watch_chromium.org, gspencer+watch_chromium.org, gauravsh+watch_chromium.org, oshima+watch_chromium.org, stevenjb+watch_chromium.org, davemoore+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Eliminate NetworkLoginObserver This is no longer necessary with the new network connect code. BUG=249532 R=gauravsh@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=217012

Patch Set 1 #

Created: 7 years, 4 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+0 lines, -134 lines)			Patch
M	chrome/browser/chromeos/cros/network_library_impl_base.h	View	2 chunks	+0 lines, -5 lines	0 comments	Download
M	chrome/browser/chromeos/cros/network_library_impl_base.cc	View	2 chunks	+0 lines, -3 lines	0 comments	Download
D	chrome/browser/chromeos/network_login_observer.h	View	1 chunk	+0 lines, -40 lines	0 comments	Download
D	chrome/browser/chromeos/network_login_observer.cc	View	1 chunk	+0 lines, -84 lines	0 comments	Download
M	chrome/chrome_browser_chromeos.gypi	View	1 chunk	+0 lines, -2 lines	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/stevenjb@chromium.org/22761002/1

7 years, 4 months ago (2013-08-10 00:29:36 UTC) #3

commit-bot: I haz the power

Step "update" is always a major failure. Look at the try server FAQ for more ...

7 years, 4 months ago (2013-08-10 00:52:05 UTC) #4

stevenjb

7 years, 4 months ago (2013-08-12 16:36:10 UTC) #5

Message was sent while issue was closed.

Committed patchset #1 manually as r217012 (presubmit successful).

Expand Messages | Collapse Messages