Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(25)

Issue 2276033004: Make chromium canary recipe explicitly set GIT_MODE (Closed)

Created:
4 years, 3 months ago by agable
Modified:
4 years, 3 months ago
Reviewers:
iannucci
CC:
chromium-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Make chromium canary recipe explicitly set GIT_MODE This is completely safe because this recipe isn't used for anything. TBR=iannucci@chromium.org BUG=640251 Committed: https://chromium.googlesource.com/chromium/src/+/de30c52542965c81a6704b093bdf1721cfe88850

Patch Set 1 #

Patch Set 2 : Make chromium canary recipe explicitly set GIT_MODE #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M infra/recipes/canary.py View 1 chunk +1 line, -1 line 0 comments Download
M infra/recipes/canary.expected/basic.json View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 6 (3 generated)
agable
4 years, 3 months ago (2016-08-25 02:17:37 UTC) #1
commit-bot: I haz the power
Patchset 2 (id:??) landed as https://crrev.com/de30c52542965c81a6704b093bdf1721cfe88850 Cr-Commit-Position: refs/heads/master@{#414275}
4 years, 3 months ago (2016-08-25 02:45:13 UTC) #4
agable
4 years, 3 months ago (2016-08-25 02:46:41 UTC) #6
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as
de30c52542965c81a6704b093bdf1721cfe88850 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698