Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(245)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2276033003: Correctly use sdk passed on command-line (Closed)

Created:
4 years, 4 months ago by Brian Wilkerson
Modified:
4 years, 4 months ago
Reviewers:
scheglov
CC:
reviews_dartlang.org
Base URL:
https://github.com/dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+125 lines, -14 lines) Patch
M pkg/analysis_server/lib/src/server/driver.dart View 1 chunk +2 lines, -2 lines 0 comments Download
A pkg/analysis_server/test/integration/analysis/get_errors_nonStandard_sdk.dart View 1 chunk +96 lines, -0 lines 2 comments Download
M pkg/analysis_server/test/integration/analysis/test_all.dart View 2 chunks +2 lines, -0 lines 0 comments Download
M pkg/analysis_server/test/integration/integration_tests.dart View 3 chunks +15 lines, -2 lines 0 comments Download
M pkg/analysis_server/test/mock_sdk.dart View 9 chunks +10 lines, -10 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
Brian Wilkerson
4 years, 4 months ago (2016-08-24 18:27:36 UTC) #2
scheglov
LGTM https://codereview.chromium.org/2276033003/diff/1/pkg/analysis_server/test/integration/analysis/get_errors_nonStandard_sdk.dart File pkg/analysis_server/test/integration/analysis/get_errors_nonStandard_sdk.dart (right): https://codereview.chromium.org/2276033003/diff/1/pkg/analysis_server/test/integration/analysis/get_errors_nonStandard_sdk.dart#newcode28 pkg/analysis_server/test/integration/analysis/get_errors_nonStandard_sdk.dart:28: * Base class for testing the "analysis.getErrors" request. ...
4 years, 4 months ago (2016-08-24 18:37:20 UTC) #3
Brian Wilkerson
https://codereview.chromium.org/2276033003/diff/1/pkg/analysis_server/test/integration/analysis/get_errors_nonStandard_sdk.dart File pkg/analysis_server/test/integration/analysis/get_errors_nonStandard_sdk.dart (right): https://codereview.chromium.org/2276033003/diff/1/pkg/analysis_server/test/integration/analysis/get_errors_nonStandard_sdk.dart#newcode28 pkg/analysis_server/test/integration/analysis/get_errors_nonStandard_sdk.dart:28: * Base class for testing the "analysis.getErrors" request. Done, ...
4 years, 4 months ago (2016-08-24 19:38:12 UTC) #4
Brian Wilkerson
4 years, 4 months ago (2016-08-24 19:38:25 UTC) #6
Message was sent while issue was closed. 
Committed patchset #1 (id:1) manually as
40a310748a2662797b2a674c8ab343bd4eca4a2a (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698