third_party/WebKit/Source/core/html/HTMLVideoElementTest.cpp - Issue 2276033002: Pass SkPaint instead of its alpha and mode in WebMediaPlayer::paint

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/html/HTMLVideoElementTest.cpp

Issue 2276033002: Pass SkPaint instead of its alpha and mode in WebMediaPlayer::paint (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: update layout expectation Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« third_party/WebKit/LayoutTests/fast/canvas/canvas-drawImage-video-imageSmoothingEnabled.html ('K') | « third_party/WebKit/Source/core/html/HTMLVideoElement.cpp ('k') | third_party/WebKit/Source/core/paint/VideoPainterTest.cpp » ('j') | third_party/WebKit/public/platform/WebMediaPlayer.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/html/HTMLVideoElementTest.cpp

diff --git a/third_party/WebKit/Source/core/html/HTMLVideoElementTest.cpp b/third_party/WebKit/Source/core/html/HTMLVideoElementTest.cpp

index d50e429a3777a58bd47feea77582c39eaad14e73..f4687c20d93d0ed814a72c188c0e0d34fc150479 100644

--- a/third_party/WebKit/Source/core/html/HTMLVideoElementTest.cpp

+++ b/third_party/WebKit/Source/core/html/HTMLVideoElementTest.cpp

@@ -51,7 +51,7 @@ public:

unsigned droppedFrameCount() const override { return 0; };

size_t audioDecodedByteCount() const override { return 0; };

size_t videoDecodedByteCount() const override { return 0; };

- void paint(WebCanvas*, const WebRect&, unsigned char alpha, SkXfermode::Mode) override { };

+ void paint(WebCanvas*, const WebRect&, const SkPaint*) override { };

};

class MockWebMediaPlayer : public EmptyWebMediaPlayer {