Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(580)

Unified Diff: media/blink/webmediaplayer_impl.cc

Issue 2276033002: Pass SkPaint instead of its alpha and mode in WebMediaPlayer::paint (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: update layout expectation Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: media/blink/webmediaplayer_impl.cc
diff --git a/media/blink/webmediaplayer_impl.cc b/media/blink/webmediaplayer_impl.cc
index 4127fba19f4e0b98416be476f33d64d379fa81ac..af1a228936c1be49ab3f3384b22bf8afd4bc3bbb 100644
--- a/media/blink/webmediaplayer_impl.cc
+++ b/media/blink/webmediaplayer_impl.cc
@@ -756,8 +756,7 @@ bool WebMediaPlayerImpl::didLoadingProgress() {
void WebMediaPlayerImpl::paint(blink::WebCanvas* canvas,
const blink::WebRect& rect,
- unsigned char alpha,
- SkXfermode::Mode mode) {
+ const SkPaint* paint) {
DCHECK(main_task_runner_->BelongsToCurrentThread());
TRACE_EVENT0("media", "WebMediaPlayerImpl:paint");
@@ -777,7 +776,7 @@ void WebMediaPlayerImpl::paint(blink::WebCanvas* canvas,
return; // The context has been lost since and can't setup a GrContext.
}
skcanvas_video_renderer_.Paint(video_frame, canvas, gfx::RectF(gfx_rect),
- alpha, mode, pipeline_metadata_.video_rotation,
+ paint, pipeline_metadata_.video_rotation,
context_3d);
}

Powered by Google App Engine
This is Rietveld 408576698