content/renderer/media/html_video_element_capturer_source_unittest.cc - Issue 2276033002: Pass SkPaint instead of its alpha and mode in WebMediaPlayer::paint

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/renderer/media/html_video_element_capturer_source_unittest.cc

Issue 2276033002: Pass SkPaint instead of its alpha and mode in WebMediaPlayer::paint (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: update layout expectation Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « content/renderer/media/html_video_element_capturer_source.cc ('k') | content/renderer/media/webmediaplayer_ms.h » ('j') | media/renderers/skcanvas_video_renderer.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/renderer/media/html_video_element_capturer_source_unittest.cc

diff --git a/content/renderer/media/html_video_element_capturer_source_unittest.cc b/content/renderer/media/html_video_element_capturer_source_unittest.cc

index 2bb3292d9889edfb68f466ae60134cef734cd8ae..c88a4bfe3cc12ebc33626d9cfbeecc896626bc9e 100644

--- a/content/renderer/media/html_video_element_capturer_source_unittest.cc

+++ b/content/renderer/media/html_video_element_capturer_source_unittest.cc

@@ -74,8 +74,7 @@ class MockWebMediaPlayer : public blink::WebMediaPlayer,

void paint(blink::WebCanvas* canvas,

const blink::WebRect& paint_rectangle,

- unsigned char alpha,

- SkXfermode::Mode mode) override {

+ const SkPaint*) override {

// We could fill in |canvas| with a meaningful pattern in ARGB and verify

// that is correctly captured (as I420) by HTMLVideoElementCapturerSource

// but I don't think that'll be easy/useful/robust, so just let go here.