Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1348)

Unified Diff: media/renderers/skcanvas_video_renderer_unittest.cc

Issue 2276033002: Pass SkPaint instead of its alpha and mode in WebMediaPlayer::paint (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: android should compile Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « media/renderers/skcanvas_video_renderer.cc ('k') | third_party/WebKit/LayoutTests/TestExpectations » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: media/renderers/skcanvas_video_renderer_unittest.cc
diff --git a/media/renderers/skcanvas_video_renderer_unittest.cc b/media/renderers/skcanvas_video_renderer_unittest.cc
index 1fae1d88a17a8be1abcb6002cd086c1cd7ce814d..38141c12d500daf4059b8b4bc679ae416145820c 100644
--- a/media/renderers/skcanvas_video_renderer_unittest.cc
+++ b/media/renderers/skcanvas_video_renderer_unittest.cc
@@ -206,8 +206,10 @@ SkCanvasVideoRendererTest::SkCanvasVideoRendererTest()
SkCanvasVideoRendererTest::~SkCanvasVideoRendererTest() {}
void SkCanvasVideoRendererTest::PaintWithoutFrame(SkCanvas* canvas) {
- renderer_.Paint(nullptr, canvas, kNaturalRect, 0xFF,
- SkXfermode::kSrcOver_Mode, VIDEO_ROTATION_0, Context3D());
+ SkPaint paint;
+ paint.setFilterQuality(kLow_SkFilterQuality);
+ renderer_.Paint(nullptr, canvas, kNaturalRect, paint, VIDEO_ROTATION_0,
+ Context3D());
}
void SkCanvasVideoRendererTest::Paint(
@@ -238,7 +240,11 @@ void SkCanvasVideoRendererTest::PaintRotated(
media::FillYUV(video_frame.get(), 29, 255, 107);
break;
}
- renderer_.Paint(video_frame, canvas, dest_rect, 0xFF, mode, video_rotation,
+ SkPaint paint;
+ paint.setXfermodeMode(mode);
+ paint.setAlpha(0xFF);
+ paint.setFilterQuality(kLow_SkFilterQuality);
+ renderer_.Paint(video_frame, canvas, dest_rect, paint, video_rotation,
Context3D());
}
@@ -536,7 +542,9 @@ TEST_F(SkCanvasVideoRendererTest, ContextLost) {
PIXEL_FORMAT_UYVY, holders, base::Bind(MailboxHoldersReleased), size,
gfx::Rect(size), size, kNoTimestamp);
- renderer_.Paint(video_frame, &canvas, kNaturalRect, 0xFF,
- SkXfermode::kSrcOver_Mode, VIDEO_ROTATION_90, context_3d);
+ SkPaint paint;
+ paint.setFilterQuality(kLow_SkFilterQuality);
+ renderer_.Paint(video_frame, &canvas, kNaturalRect, paint, VIDEO_ROTATION_90,
+ context_3d);
}
} // namespace media
« no previous file with comments | « media/renderers/skcanvas_video_renderer.cc ('k') | third_party/WebKit/LayoutTests/TestExpectations » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698