media/renderers/skcanvas_video_renderer.h - Issue 2276033002: Pass SkPaint instead of its alpha and mode in WebMediaPlayer::paint

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: media/renderers/skcanvas_video_renderer.h

Issue 2276033002: Pass SkPaint instead of its alpha and mode in WebMediaPlayer::paint (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: android should compile Created 4 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: media/renderers/skcanvas_video_renderer.h

diff --git a/media/renderers/skcanvas_video_renderer.h b/media/renderers/skcanvas_video_renderer.h

index ff2a9195db5d7dc22fe4b44526642c27f735d119..86222fb55e8abd9d72d3547f97575cc3d2bb9f10 100644

--- a/media/renderers/skcanvas_video_renderer.h

+++ b/media/renderers/skcanvas_video_renderer.h

@@ -47,8 +47,7 @@ class MEDIA_EXPORT SkCanvasVideoRenderer {

void Paint(const scoped_refptr<VideoFrame>& video_frame,

SkCanvas* canvas,

const gfx::RectF& dest_rect,

- uint8_t alpha,

- SkXfermode::Mode mode,

+ SkPaint& paint,

VideoRotation video_rotation,

const Context3D& context_3d);

« no previous file with comments | « media/blink/webmediaplayer_impl.cc ('k') | media/renderers/skcanvas_video_renderer.cc » ('j') | no next file with comments »