content/renderer/media/webmediaplayer_ms.h - Issue 2276033002: Pass SkPaint instead of its alpha and mode in WebMediaPlayer::paint

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/renderer/media/webmediaplayer_ms.h

Issue 2276033002: Pass SkPaint instead of its alpha and mode in WebMediaPlayer::paint (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: android should compile Created 4 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « content/renderer/media/html_video_element_capturer_source_unittest.cc ('k') | content/renderer/media/webmediaplayer_ms.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/renderer/media/webmediaplayer_ms.h

diff --git a/content/renderer/media/webmediaplayer_ms.h b/content/renderer/media/webmediaplayer_ms.h

index 33e60b7bbbc24606416a081a2a253c856796f2b3..a0cc00e41af6615b310c0a8fe133bdb06d5d6040 100644

--- a/content/renderer/media/webmediaplayer_ms.h

+++ b/content/renderer/media/webmediaplayer_ms.h

@@ -106,8 +106,7 @@ class CONTENT_EXPORT WebMediaPlayerMS

// Methods for painting.

void paint(blink::WebCanvas* canvas,

const blink::WebRect& rect,

- unsigned char alpha,

- SkXfermode::Mode mode) override;

+ SkPaint& paint) override;

media::SkCanvasVideoRenderer* GetSkCanvasVideoRenderer();

void ResetCanvasCache();