content/renderer/media/android/webmediaplayer_android.h - Issue 2276033002: Pass SkPaint instead of its alpha and mode in WebMediaPlayer::paint

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/renderer/media/android/webmediaplayer_android.h

Issue 2276033002: Pass SkPaint instead of its alpha and mode in WebMediaPlayer::paint (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: android should compile Created 4 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: content/renderer/media/android/webmediaplayer_android.h

diff --git a/content/renderer/media/android/webmediaplayer_android.h b/content/renderer/media/android/webmediaplayer_android.h

index 77e1b7de1b1a06cdf94da62cf1fe1ffc69110cc3..f18a8d119dced88e6d6bbad5b6c15e422993fa1d 100644

--- a/content/renderer/media/android/webmediaplayer_android.h

+++ b/content/renderer/media/android/webmediaplayer_android.h

@@ -133,8 +133,7 @@ class WebMediaPlayerAndroid

// https://code.google.com/p/skia/issues/detail?id=1189

void paint(blink::WebCanvas* canvas,

const blink::WebRect& rect,

- unsigned char alpha,

- SkXfermode::Mode mode) override;

+ SkPaint&) override;

bool copyVideoTextureToPlatformTexture(gpu::gles2::GLES2Interface* gl,

unsigned int texture,

« no previous file with comments | « no previous file | content/renderer/media/android/webmediaplayer_android.cc » ('j') | no next file with comments »