third_party/WebKit/LayoutTests/fast/canvas/canvas-drawImage-video-imageSmoothingEnabled.html - Issue 2276033002: Pass SkPaint instead of its alpha and mode in WebMediaPlayer::paint

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: third_party/WebKit/LayoutTests/fast/canvas/canvas-drawImage-video-imageSmoothingEnabled.html

Issue 2276033002: Pass SkPaint instead of its alpha and mode in WebMediaPlayer::paint (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: update layout expectation Created 4 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« third_party/WebKit/LayoutTests/TestExpectations ('K') | « third_party/WebKit/LayoutTests/fast/canvas/canvas-composite-video-shadow-expected.txt ('k') | third_party/WebKit/Source/core/html/HTMLVideoElement.cpp » ('j') | third_party/WebKit/public/platform/WebMediaPlayer.h » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
(Empty)
	1 <!DOCTYPE HTML>

	2 <script src="../../resources/testharness.js"></script>

	3 <script src="../../resources/testharnessreport.js"></script>

	4 <script>

	5 function createNewCanvas(width, height)

	6 {

	7 var canvas = document.createElement("canvas");

	8 canvas.width = width;

	9 canvas.height = height;

	10 var ctx = canvas.getContext("2d");

	11 ctx.clearRect(0, 0, width, height);

	12 return ctx;

	13 }

	14

	15 function compareTwoCanvases(ctx1, ctx2, width, height)

	16 {

	17 var data1 = ctx1.getImageData(0, 0, width, height).data;

	18 var data2 = ctx2.getImageData(0, 0, width, height).data;

	19 var dataMatched = true;

	20 for (var i = 0; i < data1.length; i++) {

	21 if (data1[i] != data2[i]) {

	22 dataMatched = false;

	23 break;

	24 }

	25 }

	26 assert_false(dataMatched);

	27 }

	28

	29 async_test(function(t) {

	30 var video = document.createElement("video");

	31 video.oncanplaythrough = t.step_func_done(function() {

	32 video.pause();

	33 var width = 100;

	34 var height = 100;

	35 var ctx1 = createNewCanvas(width, height);

	36 var ctx2 = createNewCanvas(width, height);

	37 ctx1.imageSmoothingEnabled = true;

	38 ctx1.imageSmoothingQuality = 'low';

	39 ctx2.imageSmoothingEnabled = true;

	40 ctx2.imageSmoothingQuality = 'high';

	41 ctx1.drawImage(video, 0, 0, video.videoWidth, video.videoHeight, 0, 0, w idth, height);

	42 ctx2.drawImage(video, 0, 0, video.videoWidth, video.videoHeight, 0, 0, w idth, height);

	43 compareTwoCanvases(ctx1, ctx2, width, height);

	44 });

	45 video.src = "../../compositing/resources/video.ogv";

	46 }, 'createImageBitmap from a HTMLVideoElement with resize option.');
	Justin Novosad 2016/08/25 19:18:19 Wrong text here. Wrong text here. xidachen 2016/08/26 02:21:39 Done. Show quoted text On 2016/08/25 19:18:19, Justin Novosad wrote: > Wrong text here. Done.
	47 </script>

OLD	NEW