Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(147)

Issue 227603003: Clarify the .gclient URL mismatch error message (Closed)

Created:
6 years, 8 months ago by borenet
Modified:
6 years, 8 months ago
CC:
chromium-reviews, Dirk Pranke, cmp-cc_chromium.org, M-A Ruel, iannucci+depot_tools_chromium.org, ilevy-cc_chromium.org
Visibility:
Public.

Description

Clarify the .gclient URL mismatch error message BUG= Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=262182

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -2 lines) Patch
M gclient.py View 1 chunk +5 lines, -2 lines 0 comments Download

Messages

Total messages: 11 (0 generated)
borenet
The use of "expected" vs "actual" seems to be confusing. This should clarify a bit.
6 years, 8 months ago (2014-04-07 13:28:14 UTC) #1
Nico
lgtm
6 years, 8 months ago (2014-04-07 15:40:06 UTC) #2
borenet
The CQ bit was checked by borenet@google.com
6 years, 8 months ago (2014-04-07 17:26:57 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/borenet@google.com/227603003/1
6 years, 8 months ago (2014-04-07 17:27:06 UTC) #4
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 8 months ago (2014-04-07 17:29:20 UTC) #5
commit-bot: I haz the power
Presubmit check for 227603003-1 failed and returned exit status 1. Running presubmit commit checks ...
6 years, 8 months ago (2014-04-07 17:29:20 UTC) #6
borenet
+a bunch of people for quick review
6 years, 8 months ago (2014-04-07 19:53:36 UTC) #7
M-A Ruel
lgtm
6 years, 8 months ago (2014-04-07 20:02:47 UTC) #8
borenet
The CQ bit was checked by borenet@google.com
6 years, 8 months ago (2014-04-07 20:03:47 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/borenet@google.com/227603003/1
6 years, 8 months ago (2014-04-07 20:03:52 UTC) #10
commit-bot: I haz the power
6 years, 8 months ago (2014-04-07 20:06:03 UTC) #11
Message was sent while issue was closed.
Change committed as 262182

Powered by Google App Engine
This is Rietveld 408576698