Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(35)

Issue 2276003002: [turbofan] Allow tests to enable/disable instruction scheduling. (Closed)

Created:
4 years, 4 months ago by baptiste.afsa1
Modified:
4 years, 4 months ago
Reviewers:
Benedikt Meurer, Jarin
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[turbofan] Allow tests to enable/disable instruction scheduling. Some instruction selection tests rely on the instructions to be emitted in a specific order. R=jarin@chromium.org, bmeurer@chromium.org Committed: https://crrev.com/65ba1cdeb6f8c5e65ac7926168af1c0b9c5e042f Cr-Commit-Position: refs/heads/master@{#38886}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+20 lines, -11 lines) Patch
M src/compiler/instruction-selector.h View 3 chunks +11 lines, -1 line 0 comments Download
M src/compiler/instruction-selector.cc View 6 chunks +7 lines, -9 lines 0 comments Download
M test/unittests/compiler/instruction-selector-unittest.cc View 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 9 (4 generated)
baptiste.afsa1
PTAL
4 years, 4 months ago (2016-08-24 14:22:48 UTC) #1
Benedikt Meurer
lgtm
4 years, 4 months ago (2016-08-24 17:41:09 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2276003002/1
4 years, 4 months ago (2016-08-25 07:42:57 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 4 months ago (2016-08-25 08:05:02 UTC) #7
commit-bot: I haz the power
4 years, 4 months ago (2016-08-25 08:05:26 UTC) #9
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/65ba1cdeb6f8c5e65ac7926168af1c0b9c5e042f
Cr-Commit-Position: refs/heads/master@{#38886}

Powered by Google App Engine
This is Rietveld 408576698