Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(327)

Issue 2275983004: GN: Android (Closed)

Created:
4 years, 3 months ago by mtklein_C
Modified:
4 years, 3 months ago
Reviewers:
herb_g
CC:
reviews_skia.org, jcgregorio, djsollen
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

GN: Android Once you have downloaded an android NDK, you can set the ndk GN arg to use it. E.g. my gn.args looks like: is_debug = false ndk = "/opt/android-ndk" This should be enough to get you going for an arm64 build. You ought to be able to tweak that to other architectures by changing target_cpu to "arm", "x86", "x86-64", etc. That won't quite work until I follow this up a bit, but the skeleton is there. This is enough to get me compiled, linked, and running to completion on my N5x. BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2275983004 Committed: https://skia.googlesource.com/skia/+/7d6fb2c92d096ac3630e23d561a4077a974a815c

Patch Set 1 #

Patch Set 2 : everything off ndk #

Patch Set 3 : more #

Patch Set 4 : build freetype #

Patch Set 5 : everything builds and links #

Patch Set 6 : pie #

Patch Set 7 : save #

Patch Set 8 : getting tidier #

Patch Set 9 : finish up tidying #

Patch Set 10 : simplify pthread #

Patch Set 11 : implicit pthread #

Patch Set 12 : continue using system freetype on Linux #

Patch Set 13 : note #

Unified diffs Side-by-side diffs Delta from patch set Stats (+196 lines, -36 lines) Patch
M BUILD.gn View 1 2 3 4 5 6 7 8 9 10 11 10 chunks +37 lines, -20 lines 0 comments Download
M gn/BUILD.gn View 1 2 3 4 5 6 7 8 9 10 11 12 2 chunks +40 lines, -0 lines 0 comments Download
M gn/BUILDCONFIG.gn View 1 2 3 4 5 6 7 8 3 chunks +23 lines, -0 lines 0 comments Download
M src/core/SkCpu.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/BUILD.gn View 1 2 3 1 chunk +0 lines, -8 lines 0 comments Download
A third_party/cpu-features/BUILD.gn View 1 chunk +17 lines, -0 lines 0 comments Download
A third_party/freetype2/BUILD.gn View 1 2 3 4 5 6 7 8 9 10 11 1 chunk +63 lines, -0 lines 0 comments Download
M third_party/icu/BUILD.gn View 1 2 1 chunk +1 line, -5 lines 0 comments Download
M third_party/libpng/BUILD.gn View 1 2 1 chunk +7 lines, -0 lines 0 comments Download
M third_party/libwebp/BUILD.gn View 1 2 1 chunk +6 lines, -0 lines 0 comments Download
M third_party/sfntly/BUILD.gn View 1 2 3 4 5 6 7 8 9 10 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 22 (16 generated)
mtklein_C
4 years, 3 months ago (2016-08-25 21:19:26 UTC) #15
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2275983004/220001
4 years, 3 months ago (2016-08-25 21:19:29 UTC) #16
commit-bot: I haz the power
Note for Reviewers: The CQ is waiting for an approval. If you believe that the ...
4 years, 3 months ago (2016-08-25 21:19:31 UTC) #17
herb_g
lgtm
4 years, 3 months ago (2016-08-25 21:20:27 UTC) #18
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2275983004/240001
4 years, 3 months ago (2016-08-25 21:27:51 UTC) #20
commit-bot: I haz the power
4 years, 3 months ago (2016-08-25 21:50:47 UTC) #22
Message was sent while issue was closed.
Committed patchset #13 (id:240001) as
https://skia.googlesource.com/skia/+/7d6fb2c92d096ac3630e23d561a4077a974a815c

Powered by Google App Engine
This is Rietveld 408576698