Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(298)

Issue 2275983002: Domain Reliability: Update Google domain list. (Closed)

Created:
4 years, 4 months ago by Julia Tuttle
Modified:
4 years, 3 months ago
Reviewers:
cbentzel
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Domain Reliability: Update Google domain list. BUG=640612 Committed: https://crrev.com/c0e117d2fe9286c7af63947cfe7695164ade6850 Cr-Commit-Position: refs/heads/master@{#414487}

Patch Set 1 #

Total comments: 3

Patch Set 2 : Fix sort order. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+18 lines, -11 lines) Patch
M components/domain_reliability/google_configs.cc View 1 6 chunks +18 lines, -11 lines 0 comments Download

Messages

Total messages: 24 (14 generated)
Julia Tuttle
PTAL, cbentzel.
4 years, 4 months ago (2016-08-24 14:05:11 UTC) #3
cbentzel
Please add a bug associated with this.
4 years, 4 months ago (2016-08-24 14:08:32 UTC) #5
cbentzel
https://codereview.chromium.org/2275983002/diff/1/components/domain_reliability/google_configs.cc File components/domain_reliability/google_configs.cc (right): https://codereview.chromium.org/2275983002/diff/1/components/domain_reliability/google_configs.cc#newcode257 components/domain_reliability/google_configs.cc:257: // google.com is a special case. We have a ...
4 years, 4 months ago (2016-08-24 14:11:44 UTC) #7
Julia Tuttle
On 2016/08/24 14:11:44, cbentzel wrote: > https://codereview.chromium.org/2275983002/diff/1/components/domain_reliability/google_configs.cc > File components/domain_reliability/google_configs.cc (right): > > https://codereview.chromium.org/2275983002/diff/1/components/domain_reliability/google_configs.cc#newcode257 > ...
4 years, 4 months ago (2016-08-24 14:13:10 UTC) #8
cbentzel
Please do confirmations on these. On Wed, Aug 24, 2016 at 10:13 AM <juliatuttle@chromium.org> wrote: ...
4 years, 4 months ago (2016-08-24 14:15:11 UTC) #9
cbentzel
On 2016/08/24 14:15:11, cbentzel wrote: > Please do confirmations on these. We have confirmations on ...
4 years, 4 months ago (2016-08-24 14:45:24 UTC) #10
cbentzel
On 2016/08/24 14:45:24, cbentzel wrote: > On 2016/08/24 14:15:11, cbentzel wrote: > > Please do ...
4 years, 4 months ago (2016-08-24 17:01:38 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2275983002/20001
4 years, 3 months ago (2016-08-25 18:30:15 UTC) #20
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 3 months ago (2016-08-25 18:37:26 UTC) #22
commit-bot: I haz the power
4 years, 3 months ago (2016-08-25 18:40:20 UTC) #24
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/c0e117d2fe9286c7af63947cfe7695164ade6850
Cr-Commit-Position: refs/heads/master@{#414487}

Powered by Google App Engine
This is Rietveld 408576698