|
|
Created:
4 years, 4 months ago by Julia Tuttle Modified:
4 years, 3 months ago Reviewers:
cbentzel CC:
chromium-reviews Base URL:
https://chromium.googlesource.com/chromium/src.git@master Target Ref:
refs/pending/heads/master Project:
chromium Visibility:
Public. |
DescriptionDomain Reliability: Update Google domain list.
BUG=640612
Committed: https://crrev.com/c0e117d2fe9286c7af63947cfe7695164ade6850
Cr-Commit-Position: refs/heads/master@{#414487}
Patch Set 1 #
Total comments: 3
Patch Set 2 : Fix sort order. #Messages
Total messages: 24 (14 generated)
The CQ bit was checked by juliatuttle@chromium.org to run a CQ dry run
juliatuttle@chromium.org changed reviewers: + cbentzel@chromium.org
PTAL, cbentzel.
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Please add a bug associated with this.
Description was changed from ========== Domain Reliability: Update Google domain list. BUG= ========== to ========== Domain Reliability: Update Google domain list. BUG=640612 ==========
https://codereview.chromium.org/2275983002/diff/1/components/domain_reliabili... File components/domain_reliability/google_configs.cc (right): https://codereview.chromium.org/2275983002/diff/1/components/domain_reliabili... components/domain_reliability/google_configs.cc:257: // google.com is a special case. We have a custom config for www.google.com, Nit: I'd add a newline between l.google.com and google.com as this is effectively a different section. Would also explain why not lexicographically sorted. https://codereview.chromium.org/2275983002/diff/1/components/domain_reliabili... components/domain_reliability/google_configs.cc:324: { "google.stackdriver.com", true, false, false }, Nit: this seems out of order https://codereview.chromium.org/2275983002/diff/1/components/domain_reliabili... components/domain_reliability/google_configs.cc:350: { "gvt3.com", true, false, false }, What are these?
On 2016/08/24 14:11:44, cbentzel wrote: > https://codereview.chromium.org/2275983002/diff/1/components/domain_reliabili... > File components/domain_reliability/google_configs.cc (right): > > https://codereview.chromium.org/2275983002/diff/1/components/domain_reliabili... > components/domain_reliability/google_configs.cc:257: // http://google.com is a special > case. We have a custom config for http://www.google.com, > Nit: I'd add a newline between http://l.google.com and http://google.com as this is > effectively a different section. Would also explain why not lexicographically > sorted. > > https://codereview.chromium.org/2275983002/diff/1/components/domain_reliabili... > components/domain_reliability/google_configs.cc:324: { "google.stackdriver.com", > true, false, false }, > Nit: this seems out of order Right now I'm just mirroring the internal list. Is it worth correcting those mistakes? We're not doing binary search on this list or anything. > https://codereview.chromium.org/2275983002/diff/1/components/domain_reliabili... > components/domain_reliability/google_configs.cc:350: { "gvt3.com", true, false, > false }, > What are these? No idea! But Google owns them. I can ask internally if you'd like.
Please do confirmations on these. On Wed, Aug 24, 2016 at 10:13 AM <juliatuttle@chromium.org> wrote: > On 2016/08/24 14:11:44, cbentzel wrote: > > > > https://codereview.chromium.org/2275983002/diff/1/components/domain_reliabili... > > File components/domain_reliability/google_configs.cc (right): > > > > > > https://codereview.chromium.org/2275983002/diff/1/components/domain_reliabili... > > components/domain_reliability/google_configs.cc:257: // > http://google.com is a > special > > case. We have a custom config for http://www.google.com, > > Nit: I'd add a newline between http://l.google.com and http://google.com > as > this is > > effectively a different section. Would also explain why not > lexicographically > > sorted. > > > > > > https://codereview.chromium.org/2275983002/diff/1/components/domain_reliabili... > > components/domain_reliability/google_configs.cc:324: { > > "google.stackdriver.com", > > true, false, false }, > > Nit: this seems out of order > > Right now I'm just mirroring the internal list. Is it worth correcting > those > mistakes? We're not doing binary search on this list or anything. > > > > > https://codereview.chromium.org/2275983002/diff/1/components/domain_reliabili... > > components/domain_reliability/google_configs.cc:350: { "gvt3.com", true, > false, > > false }, > > What are these? > > No idea! But Google owns them. I can ask internally if you'd like. > > https://codereview.chromium.org/2275983002/ > -- You received this message because you are subscribed to the Google Groups "Chromium-reviews" group. To unsubscribe from this group and stop receiving emails from it, send an email to chromium-reviews+unsubscribe@chromium.org.
On 2016/08/24 14:15:11, cbentzel wrote: > Please do confirmations on these. We have confirmations on these.
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
On 2016/08/24 14:45:24, cbentzel wrote: > On 2016/08/24 14:15:11, cbentzel wrote: > > Please do confirmations on these. > > We have confirmations on these. LGTM
The CQ bit was checked by juliatuttle@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
The CQ bit was checked by juliatuttle@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from cbentzel@chromium.org Link to the patchset: https://codereview.chromium.org/2275983002/#ps20001 (title: "Fix sort order.")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Message was sent while issue was closed.
Description was changed from ========== Domain Reliability: Update Google domain list. BUG=640612 ========== to ========== Domain Reliability: Update Google domain list. BUG=640612 ==========
Message was sent while issue was closed.
Committed patchset #2 (id:20001)
Message was sent while issue was closed.
Description was changed from ========== Domain Reliability: Update Google domain list. BUG=640612 ========== to ========== Domain Reliability: Update Google domain list. BUG=640612 Committed: https://crrev.com/c0e117d2fe9286c7af63947cfe7695164ade6850 Cr-Commit-Position: refs/heads/master@{#414487} ==========
Message was sent while issue was closed.
Patchset 2 (id:??) landed as https://crrev.com/c0e117d2fe9286c7af63947cfe7695164ade6850 Cr-Commit-Position: refs/heads/master@{#414487} |