Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(77)

Issue 2275943004: Revert of Experimental parsing expression grammar (PEG) template library (Closed)

Created:
4 years, 3 months ago by f(malita)
Modified:
4 years, 3 months ago
CC:
reviews_skia.org, robertphillips, stephana
Base URL:
https://chromium.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Revert of Experimental parsing expression grammar (PEG) template library (patchset #8 id:140001 of https://codereview.chromium.org/2271743002/ ) Reason for revert: G3 roll & Msan woes. Original issue's description: > Experimental parsing expression grammar (PEG) template library > > > BUG=skia: > GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2271743002 > > Committed: https://skia.googlesource.com/skia/+/9d08cbc8c6131ff61a1e71cc5c8cf27841d62b42 TBR=mtklein@google.com,bungeman@google.com,reed@google.com # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=skia: Committed: https://skia.googlesource.com/skia/+/0172e77ad6b73d56b57d1b5387e5bd3a9341228a

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -547 lines) Patch
M BUILD.gn View 1 chunk +0 lines, -1 line 0 comments Download
D experimental/svg/model/SkPEG.h View 1 chunk +0 lines, -244 lines 0 comments Download
M gyp/svg.gyp View 1 chunk +0 lines, -2 lines 0 comments Download
D tests/SkPEGTest.cpp View 1 chunk +0 lines, -300 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
f(malita)
Created Revert of Experimental parsing expression grammar (PEG) template library
4 years, 3 months ago (2016-08-25 12:50:06 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2275943004/1
4 years, 3 months ago (2016-08-25 12:50:20 UTC) #3
commit-bot: I haz the power
4 years, 3 months ago (2016-08-25 12:50:29 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/0172e77ad6b73d56b57d1b5387e5bd3a9341228a

Powered by Google App Engine
This is Rietveld 408576698