Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(152)

Issue 227593003: Handlify RuntimeHidden_RegExpConstructResult. (Closed)

Created:
6 years, 8 months ago by Yang
Modified:
6 years, 8 months ago
Reviewers:
mvstanton
CC:
v8-dev
Visibility:
Public.

Description

Handlify RuntimeHidden_RegExpConstructResult. R=mvstanton@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=20558

Patch Set 1 #

Total comments: 4

Patch Set 2 : fix #

Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -28 lines) Patch
M src/runtime.cc View 1 1 chunk +11 lines, -28 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
Yang
6 years, 8 months ago (2014-04-07 14:02:38 UTC) #1
mvstanton
2 questions...if the answers are good, then lgtm. :) --Michael https://codereview.chromium.org/227593003/diff/1/src/runtime.cc File src/runtime.cc (right): https://codereview.chromium.org/227593003/diff/1/src/runtime.cc#newcode2607 ...
6 years, 8 months ago (2014-04-07 14:28:49 UTC) #2
Yang
https://codereview.chromium.org/227593003/diff/1/src/runtime.cc File src/runtime.cc (right): https://codereview.chromium.org/227593003/diff/1/src/runtime.cc#newcode2607 src/runtime.cc:2607: RUNTIME_ASSERT(size >= 0 && size <= FixedArray::kMaxLength); On 2014/04/07 ...
6 years, 8 months ago (2014-04-07 14:47:01 UTC) #3
Yang
6 years, 8 months ago (2014-04-08 06:38:23 UTC) #4
Message was sent while issue was closed.
Committed patchset #2 manually as r20558 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698