chrome/browser/ui/webui/signin/get_desktop_browser.h - Issue 2275883003: [Signin Error Dialog] (2/3) Added handlers and UI constructors

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: chrome/browser/ui/webui/signin/get_desktop_browser.h

Issue 2275883003: [Signin Error Dialog] (2/3) Added handlers and UI constructors (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@error-modal-web

Patch Set: Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« no previous file with comments | « chrome/browser/profiles/profile_metrics.h ('k') | chrome/browser/ui/webui/signin/get_desktop_browser.cc » ('j') | chrome/browser/ui/webui/signin/signin_error_handler.cc » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
(Empty)
	1 // Copyright 2016 The Chromium Authors. All rights reserved.

	2 // Use of this source code is governed by a BSD-style license that can be

	3 // found in the LICENSE file.

	4

	5 #ifndef CHROME_BROWSER_UI_WEBUI_SIGNIN_GET_DESKTOP_BROWSER_H_

	6 #define CHROME_BROWSER_UI_WEBUI_SIGNIN_GET_DESKTOP_BROWSER_H_

	7

	8 namespace signin {
	tommycli 2016/08/24 17:36:41 Can this file be consolidated with get_auth_frame Can this file be consolidated with get_auth_frame into something just like signin_utils ? Does that make sense? Jane 2016/08/25 19:19:35 Done. Code-wise this makes a lot of sense, I just Show quoted text On 2016/08/24 17:36:41, tommycli wrote: > Can this file be consolidated with get_auth_frame into something just like > signin_utils ? Does that make sense? Done. Code-wise this makes a lot of sense, I just had to edit a bunch of #includes.
	9

	10 // Gets the browser containing the web UI; if none is found, returns the last

	11 // active browser for web UI's profile.

	12 Browser* GetDesktopBrowser(content::WebUI* web_ui);

	13

	14 } // namespace signin

	15

	16 #endif // CHROME_BROWSER_UI_WEBUI_SIGNIN_GET_DESKTOP_BROWSER_H_

OLD	NEW