Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(251)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2275883002: [SubZero] Branch optimization (Closed)

Created:
4 years, 4 months ago by jaydeep.patil
Modified:
4 years, 3 months ago
Reviewers:
Karl, John, mohit.bhakkad, Jim Stichnoth, srdjan.obucina, Eric Holk
CC:
native-client-reviews_googlegroups.com, rich.fuhler_imgtec.com
Base URL:
https://chromium.googlesource.com/native_client/pnacl-subzero.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Total comments: 2

Patch Set 2 : Tests added for branch optimization. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+212 lines, -26 lines) Patch
M src/IceInstMIPS32.h View 3 chunks +6 lines, -2 lines 0 comments Download
M src/IceInstMIPS32.cpp View 1 3 chunks +50 lines, -0 lines 0 comments Download
M src/IceTargetLoweringMIPS32.cpp View 1 chunk +3 lines, -3 lines 0 comments Download
M tests_lit/llvm2ice_tests/branch-opt.ll View 1 5 chunks +113 lines, -0 lines 0 comments Download
M tests_lit/llvm2ice_tests/cond-branch.ll View 1 10 chunks +40 lines, -20 lines 0 comments Download
M tests_lit/llvm2ice_tests/uncond_br.ll View 1 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 10 (3 generated)
jaydeep.patil
4 years, 4 months ago (2016-08-24 05:38:33 UTC) #3
Jim Stichnoth
1. This needs tests. Probably updating the branch-opt.ll test should be enough. 2. Please edit ...
4 years, 4 months ago (2016-08-24 15:46:11 UTC) #4
Jim Stichnoth
https://codereview.chromium.org/2275883002/diff/1/src/IceInstMIPS32.cpp File src/IceInstMIPS32.cpp (right): https://codereview.chromium.org/2275883002/diff/1/src/IceInstMIPS32.cpp#newcode212 src/IceInstMIPS32.cpp:212: if (Label) if (Label != nullptr)
4 years, 4 months ago (2016-08-24 15:51:32 UTC) #5
jaydeep.patil
https://codereview.chromium.org/2275883002/diff/1/src/IceInstMIPS32.cpp File src/IceInstMIPS32.cpp (right): https://codereview.chromium.org/2275883002/diff/1/src/IceInstMIPS32.cpp#newcode212 src/IceInstMIPS32.cpp:212: if (Label) On 2016/08/24 15:51:32, stichnot wrote: > if ...
4 years, 3 months ago (2016-08-26 10:15:00 UTC) #6
jaydeep.patil
Tests added for branch optimization. Fixed an issue in branch when next node is target ...
4 years, 3 months ago (2016-08-26 10:28:08 UTC) #7
Jim Stichnoth
lgtm
4 years, 3 months ago (2016-08-26 20:27:02 UTC) #8
Jim Stichnoth
4 years, 3 months ago (2016-08-26 20:27:45 UTC) #10
Message was sent while issue was closed. 
Committed patchset #2 (id:20001) manually as
13f0ca32f530c5d9729dcd0205a577463abd8b6b (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698