Add support for webViewContainingBlockedImage.

Add support for webViewContainingBlockedImage.

BUG=

Committed: https://crrev.com/77e8b04165bb7bb4187c3b025533fee0050a9b7d
Cr-Commit-Position: refs/heads/master@{#414160}

[justincohen, 2016-08-24 11:23:33]

justincohen@chromium.org changed reviewers:
+ baxley@chromium.org, eugenebut@chromium.org

[justincohen, 2016-08-24 11:23:34]

ptal

[Eugene But (OOO till 7-30), 2016-08-24 14:32:45]

lgtm I think getting rid of |expected_size| would be perfect, but I don't want
to block you.

https://codereview.chromium.org/2275843003/diff/1/ios/web/public/test/earl_gr...
File ios/web/public/test/earl_grey/web_view_matchers.mm (right):

https://codereview.chromium.org/2275843003/diff/1/ios/web/public/test/earl_gr...
ios/web/public/test/earl_grey/web_view_matchers.mm:106: CGSize expected_size,
Is there a reason why you can non download image in matcher? Requiring clients
to know |expected_size| seems like an inconvenient approach.

https://codereview.chromium.org/2275843003/diff/1/ios/web/public/test/earl_gr...
ios/web/public/test/earl_grey/web_view_matchers.mm:127: NSString*
evaluationResult = base::SysUTF8ToNSString(result);
s/evaluationResult/evaluation_result since it's C function which should follow
C++ Style Guide.

Same for imageAttributesAsData, imageAttributes

[Eugene But (OOO till 7-30), 2016-08-24 14:39:27]

https://codereview.chromium.org/2275843003/diff/1/ios/web/public/test/earl_gr...
File ios/web/public/test/earl_grey/web_view_matchers.mm (right):

https://codereview.chromium.org/2275843003/diff/1/ios/web/public/test/earl_gr...
ios/web/public/test/earl_grey/web_view_matchers.mm:105: id<GREYMatcher>
webViewContainingBlockedImage(std::string image_id,
Now I think I understand why you require size to pass. You don't want to pass
both id and url.

Passing only URL object can do the trick if you use this CSS selector to find
the image:

document.querySelector('img[src*="<url>"]')

[baxley, 2016-08-24 18:35:25]

LGTM

[justincohen, 2016-08-24 20:47:52]

https://codereview.chromium.org/2275843003/diff/1/ios/web/public/test/earl_gr...
File ios/web/public/test/earl_grey/web_view_matchers.mm (right):

https://codereview.chromium.org/2275843003/diff/1/ios/web/public/test/earl_gr...
ios/web/public/test/earl_grey/web_view_matchers.mm:105: id<GREYMatcher>
webViewContainingBlockedImage(std::string image_id,
On 2016/08/24 14:39:27, Eugene But wrote:
> Now I think I understand why you require size to pass. You don't want to pass
> both id and url.
> 
> Passing only URL object can do the trick if you use this CSS selector to find
> the image:
> 
> document.querySelector('img[src*="<url>"]')

Acknowledged.

https://codereview.chromium.org/2275843003/diff/1/ios/web/public/test/earl_gr...
ios/web/public/test/earl_grey/web_view_matchers.mm:106: CGSize expected_size,
On 2016/08/24 14:32:45, Eugene But wrote:
> Is there a reason why you can non download image in matcher? Requiring clients
> to know |expected_size| seems like an inconvenient approach.

Since no one else uses this?

https://codereview.chromium.org/2275843003/diff/1/ios/web/public/test/earl_gr...
ios/web/public/test/earl_grey/web_view_matchers.mm:127: NSString*
evaluationResult = base::SysUTF8ToNSString(result);
On 2016/08/24 14:32:45, Eugene But wrote:
> s/evaluationResult/evaluation_result since it's C function which should follow
> C++ Style Guide.
> 
> Same for imageAttributesAsData, imageAttributes

Done.

[justincohen, 2016-08-24 20:47:55]

The CQ bit was checked by justincohen@chromium.org

[justincohen, 2016-08-24 20:47:55]

The patchset sent to the CQ was uploaded after l-g-t-m from baxley@chromium.org,
eugenebut@chromium.org
Link to the patchset: https://codereview.chromium.org/2275843003/#ps20001
(title: "Conform to c style guide")

[commit-bot: I haz the power, 2016-08-24 20:49:22]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-24 20:53:31]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-24 20:53:32]

Try jobs failed on following builders:
  android_arm64_dbg_recipe on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_arm6...)
  android_clang_dbg_recipe on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_clan...)
  android_compile_dbg on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_comp...)
  cast_shell_android on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/cast_shell_a...)
  cast_shell_linux on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/cast_shell_linu...)
  chromeos_amd64-generic_chromium_compile_only_ng on
master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromeos_amd64-...)
  linux_chromium_chromeos_ozone_rel_ng on master.tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_chromium_chromeos_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[justincohen, 2016-08-24 20:54:42]

The CQ bit was checked by justincohen@chromium.org

[commit-bot: I haz the power, 2016-08-24 20:55:46]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-24 21:55:03]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-08-24 21:57:10]

Description was changed from

==========
Add support for webViewContainingBlockedImage.

BUG=
==========

to

==========
Add support for webViewContainingBlockedImage.

BUG=

Committed: https://crrev.com/77e8b04165bb7bb4187c3b025533fee0050a9b7d
Cr-Commit-Position: refs/heads/master@{#414160}
==========

[commit-bot: I haz the power, 2016-08-24 21:57:11]

Patchset 2 (id:??) landed as
https://crrev.com/77e8b04165bb7bb4187c3b025533fee0050a9b7d
Cr-Commit-Position: refs/heads/master@{#414160}