Enable Path2D object and some path APIs by default.

Enable Path2D object and some path APIs by default.

Enable following APIs:
  - Path2D Object Constructor & Inteface
  - void fill(Path2D, optional CanvasFillRule);
  - void stroke(Path2D);
  - void clip(Path2D, optional CanvasFillRule);
  - boolean isPointInPath(Path2D, x, y, optional CanvasFillRule);
  - boolean isPointInStroke(Path2D, x, y);

Intent to Ship:
  https://groups.google.com/a/chromium.org/forum/#!topic/blink-dev/mhjb3Em8H0A

BUG=159839, 330506
Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=171302

[zino, 2014-04-08 02:21:03]

Please take a look.

Thank you :)

[eseidel, 2014-04-08 03:35:19]

I presume there are other things guarded behind ExperimentalCanvasFeatures? 
It's generally ideal if we can just enable/disable a feature in
RuntimeEnabledFeatures.in since it makes it trivial to enable/disable on
branches if necessary.

That said, I think it's unlikely we'll need to revert his (unless this name
conflicts with window.Path2D in some major JS library, etc.)

[zino, 2014-04-08 06:51:50]

On 2014/04/08 03:35:19, eseidel wrote:
> I presume there are other things guarded behind ExperimentalCanvasFeatures? 
> It's generally ideal if we can just enable/disable a feature in
> RuntimeEnabledFeatures.in since it makes it trivial to enable/disable on
> branches if necessary.
> 
> That said, I think it's unlikely we'll need to revert his (unless this name
> conflicts with window.Path2D in some major JS library, etc.)

I think 'status=experimental' is better than 'status=stable'
because some APIs (such as addPath, addText, and so on) isn't ready yet.
Is my understanding correct? Please take a look again.

Thank you :)

[Justin Novosad, 2014-04-08 19:38:02]

This CL is entitled "Enable Path2D object and some path APIs by default."
AFAICT, that is not what this change does.

[eseidel, 2014-04-08 19:43:47]

Great.  So this isn't yet "shipping" the feature, but it is promoting it to be
seen with --experimental-web-platform-features enabled in about:flags.

LGTM

[zino, 2014-04-09 09:01:24]

Sorry, I was confusing meaning of shipping.
Justin's pointing out is right. Rik and I want "shipping".
We already exclude imperfect APIs(such as addPath, and so on) in this shipping.
CanvasPathMethods which belongs to the path object is already exposed as well.

> I presume there are other things guarded behind ExperimentalCanvasFeatures? 
> It's generally ideal if we can just enable/disable a feature in
> RuntimeEnabledFeatures.in since it makes it trivial to enable/disable on
> branches if necessary.
> 
> That said, I think it's unlikely we'll need to revert his (unless this name
> conflicts with window.Path2D in some major JS library, etc.)

I already uploaded as Patch Set2 and then I changed "status=experimental" to
"status=stable" as Patch Set 3.

Thank you.

[Rik, 2014-04-09 10:50:38]

On 2014/04/09 09:01:24, zino wrote:
> Sorry, I was confusing meaning of shipping.
> Justin's pointing out is right. Rik and I want "shipping".
> We already exclude imperfect APIs(such as addPath, and so on) in this
shipping.
> CanvasPathMethods which belongs to the path object is already exposed as well.

I don't see that you exclude addPath. Does that happen somewhere else?

[Rik, 2014-04-09 10:50:45]

https://codereview.chromium.org/227583006/diff/40001/Source/core/html/canvas/...
File Source/core/html/canvas/Path2D.idl (right):

https://codereview.chromium.org/227583006/diff/40001/Source/core/html/canvas/...
Source/core/html/canvas/Path2D.idl:36: [RaisesException] void addPath(Path2D?
path, SVGMatrix? transform);
Shouldn't this method still be experimental?
We're still figuring out the details of this API

[zino, 2014-04-09 13:25:49]

On 2014/04/09 10:50:45, Rik wrote:
>
https://codereview.chromium.org/227583006/diff/40001/Source/core/html/canvas/...
> File Source/core/html/canvas/Path2D.idl (right):
> 
>
https://codereview.chromium.org/227583006/diff/40001/Source/core/html/canvas/...
> Source/core/html/canvas/Path2D.idl:36: [RaisesException] void addPath(Path2D?
> path, SVGMatrix? transform);
> Shouldn't this method still be experimental?
> We're still figuring out the details of this API

Oh, you're right! I missed it.
I've just uploaded a new patch set.

Thank you :)

[Justin Novosad, 2014-04-09 13:58:21]

On 2014/04/09 13:25:49, zino wrote:
> On 2014/04/09 10:50:45, Rik wrote:
> >
>
https://codereview.chromium.org/227583006/diff/40001/Source/core/html/canvas/...
> > File Source/core/html/canvas/Path2D.idl (right):
> > 
> >
>
https://codereview.chromium.org/227583006/diff/40001/Source/core/html/canvas/...
> > Source/core/html/canvas/Path2D.idl:36: [RaisesException] void
addPath(Path2D?
> > path, SVGMatrix? transform);
> > Shouldn't this method still be experimental?
> > We're still figuring out the details of this API
> 
> Oh, you're right! I missed it.
> I've just uploaded a new patch set.
> 
> Thank you :)

lgtm for the code. But let's wait for approval from Eric (API owner) regarding
the shipping approach.

IMHO:  The CanvasPathMethods are already shipping via CanvasRenderingContext2D,
the only truly new method in Path2D is addPath, which remains experimental for
now.  The newly exposed methods in CanvasRenderingContext2D are variants of
methods that are already shipping that take a path arg instead of using the
built-in path.  So in all, the change does not actually expose any rendering
code that wasn't already exposed by pre-existing APIs. I think this is a very
low risk feature to ship.

[eseidel, 2014-04-09 17:45:04]

lgtm

[commit-bot: I haz the power, 2014-04-09 17:45:36]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/jinho.bang@samsung.com/227583006/60001

[commit-bot: I haz the power, 2014-04-09 18:06:31]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-04-09 18:06:32]

Try jobs failed on following builders:
  tryserver.blink on blink_presubmit

[zino, 2014-04-10 11:50:04]

The CQ bit was checked by jinho.bang@samsung.com

[commit-bot: I haz the power, 2014-04-10 11:50:11]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/jinho.bang@samsung.com/227583006/60001

[commit-bot: I haz the power, 2014-04-10 11:50:16]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-04-10 11:50:17]

Failed to apply patch for Source/core/html/canvas/Path2D.idl:
While running patch -p1 --forward --force --no-backup-if-mismatch;
  patching file Source/core/html/canvas/Path2D.idl
  Hunk #1 FAILED at 27.
  1 out of 1 hunk FAILED -- saving rejects to file
Source/core/html/canvas/Path2D.idl.rej

Patch:       Source/core/html/canvas/Path2D.idl
Index: Source/core/html/canvas/Path2D.idl
diff --git a/Source/core/html/canvas/Path2D.idl
b/Source/core/html/canvas/Path2D.idl
index
b67de6c8cff53721a25b460fd0882c475482be38..5490165a7bd716fae60ca20be12c96b131bd5b17
100644
--- a/Source/core/html/canvas/Path2D.idl
+++ b/Source/core/html/canvas/Path2D.idl
@@ -27,13 +27,13 @@
  */
 
 [
-    RuntimeEnabled=ExperimentalCanvasFeatures,
+    RuntimeEnabled=Path2D,
     Constructor,
     Constructor(Path2D path),
     Constructor(DOMString text)
 ] interface Path2D {
 
-    [RaisesException] void addPath(Path2D? path, SVGMatrix? transform);
+    [RuntimeEnabled=ExperimentalCanvasFeatures, RaisesException] void
addPath(Path2D? path, SVGMatrix? transform);
 };
 
 Path2D implements CanvasPathMethods;

[zino, 2014-04-10 12:17:40]

The CQ bit was checked by jinho.bang@samsung.com

[commit-bot: I haz the power, 2014-04-10 12:17:46]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/jinho.bang@samsung.com/227583006/80001

[commit-bot: I haz the power, 2014-04-10 12:56:33]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-04-10 12:56:34]

Try jobs failed on following builders:
  tryserver.blink on mac_blink_rel

[zino, 2014-04-10 19:27:01]

The CQ bit was checked by jinho.bang@samsung.com

[commit-bot: I haz the power, 2014-04-10 19:27:05]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/jinho.bang@samsung.com/227583006/100001

[commit-bot: I haz the power, 2014-04-10 21:05:32]

Change committed as 171302