Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(17)

Issue 2275813002: Revert of Signal extension API schema corruption to the browser process. (Closed)

Created:
4 years, 4 months ago by Wez
Modified:
4 years, 4 months ago
CC:
chromium-reviews, chromium-apps-reviews_chromium.org, extensions-reviews_chromium.org, mark a. foltz
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Signal extension API schema corruption to the browser process. (patchset #5 id:80001 of https://codereview.chromium.org/2254383002/ ) Reason for revert: Patch does not have the desired effect under Windows, which has a multi-binary installation. Original issue's description: > Signal extension API schema corruption to the browser process. > > Extension API schemas are parsed from string resources in the browser > binary, so failure to parse them usually indicates a problem with the > browser installation. > > Crashing the extension process that tried to parse the schema makes it > look to the user like the extension is at fault (or worse, in the case > of component extensions, some browser features will misbehave for no > obvious reason). > > This CL adds an IPC to indicate schema load failure back to the browser > and has the browser attempt to load the schema itself, and crash on > failure, so that the user has some indication that the browser itself > is broken (providing a better UX for this case is under review!). > > Thanks to imcheng@ for implementing the bulk of this! > > BUG=634423, 639104, 121424 > > Committed: https://crrev.com/73b8107d339588f342d4f9a92888c9a05a3707b9 > Cr-Commit-Position: refs/heads/master@{#413602} TBR=rdevlin.cronin@chromium.org,dcheng@chromium.org,nasko@chromium.org,mfoltz@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=634423, 639104, 121424 Committed: https://crrev.com/b1259fb13d6b781c0bff4530725ecf7be6a57ee5 Cr-Commit-Position: refs/heads/master@{#413901}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+13 lines, -75 lines) Patch
M extensions/browser/extension_message_filter.h View 1 chunk +0 lines, -1 line 0 comments Download
M extensions/browser/extension_message_filter.cc View 3 chunks +0 lines, -25 lines 0 comments Download
M extensions/common/extension_api.h View 1 chunk +1 line, -2 lines 0 comments Download
M extensions/common/extension_api.cc View 4 chunks +11 lines, -30 lines 0 comments Download
M extensions/common/extension_messages.h View 1 chunk +0 lines, -5 lines 0 comments Download
M extensions/renderer/v8_schema_registry.cc View 2 chunks +1 line, -12 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
Wez
Created Revert of Signal extension API schema corruption to the browser process.
4 years, 4 months ago (2016-08-24 00:00:03 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2275813002/1
4 years, 4 months ago (2016-08-24 00:00:32 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 4 months ago (2016-08-24 00:01:20 UTC) #4
commit-bot: I haz the power
4 years, 4 months ago (2016-08-24 00:03:00 UTC) #6
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/b1259fb13d6b781c0bff4530725ecf7be6a57ee5
Cr-Commit-Position: refs/heads/master@{#413901}

Powered by Google App Engine
This is Rietveld 408576698