DescriptionRevert of Signal extension API schema corruption to the browser process. (patchset #5 id:80001 of https://codereview.chromium.org/2254383002/ )
Reason for revert:
Patch does not have the desired effect under Windows, which has a multi-binary installation.
Original issue's description:
> Signal extension API schema corruption to the browser process.
>
> Extension API schemas are parsed from string resources in the browser
> binary, so failure to parse them usually indicates a problem with the
> browser installation.
>
> Crashing the extension process that tried to parse the schema makes it
> look to the user like the extension is at fault (or worse, in the case
> of component extensions, some browser features will misbehave for no
> obvious reason).
>
> This CL adds an IPC to indicate schema load failure back to the browser
> and has the browser attempt to load the schema itself, and crash on
> failure, so that the user has some indication that the browser itself
> is broken (providing a better UX for this case is under review!).
>
> Thanks to imcheng@ for implementing the bulk of this!
>
> BUG=634423, 639104, 121424
>
> Committed: https://crrev.com/73b8107d339588f342d4f9a92888c9a05a3707b9
> Cr-Commit-Position: refs/heads/master@{#413602}
TBR=rdevlin.cronin@chromium.org,dcheng@chromium.org,nasko@chromium.org,mfoltz@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=634423, 639104, 121424
Committed: https://crrev.com/b1259fb13d6b781c0bff4530725ecf7be6a57ee5
Cr-Commit-Position: refs/heads/master@{#413901}
Patch Set 1 #
Messages
Total messages: 6 (2 generated)
|