runtime/vm/raw_object_snapshot.cc - Issue 2275803002: Assign external sizes to external strings and to external typed data created by the VM.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: runtime/vm/raw_object_snapshot.cc

Issue 2275803002: Assign external sizes to external strings and to external typed data created by the VM. (Closed) Base URL: git@github.com:dart-lang/sdk.git@master

Patch Set: sync Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: runtime/vm/raw_object_snapshot.cc

diff --git a/runtime/vm/raw_object_snapshot.cc b/runtime/vm/raw_object_snapshot.cc

index d94ce4e2e4e509fe31340bced5b79bcc7e065f41..361287631b24374fa300c2e0c42fcfecd0215602 100644

--- a/runtime/vm/raw_object_snapshot.cc

+++ b/runtime/vm/raw_object_snapshot.cc

@@ -2634,7 +2634,8 @@ RawExternalTypedData* ExternalTypedData::ReadFrom(SnapshotReader* reader,

Dart_WeakPersistentHandleFinalizer callback =

reinterpret_cast<Dart_WeakPersistentHandleFinalizer>(

reader->ReadRawPointerValue());

- obj.AddFinalizer(peer, callback);

+ intptr_t external_size = obj.LengthInBytes();

+ obj.AddFinalizer(peer, callback, external_size);

return obj.raw();

}

« no previous file with comments | « runtime/vm/object.cc ('k') | no next file » | no next file with comments »