Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(245)

Unified Diff: runtime/vm/object.h

Issue 2275803002: Assign external sizes to external strings and to external typed data created by the VM. (Closed) Base URL: git@github.com:dart-lang/sdk.git@master
Patch Set: sync Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « runtime/vm/dart_api_impl.cc ('k') | runtime/vm/object.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: runtime/vm/object.h
diff --git a/runtime/vm/object.h b/runtime/vm/object.h
index b219ab7c5cdc3cbaee33f1d3eb32ac751c4469fc..f8af9df2121874442e75eddf8813e84393e05352 100644
--- a/runtime/vm/object.h
+++ b/runtime/vm/object.h
@@ -6680,7 +6680,7 @@ class String : public Instance {
// an Array object or a regular Object so that it can be traversed during
// garbage collection.
RawString* MakeExternal(void* array,
- intptr_t length,
+ intptr_t external_size,
void* peer,
Dart_PeerFinalizer cback) const;
@@ -6936,6 +6936,7 @@ class OneByteString : public AllStatic {
Heap::Space space);
static void SetPeer(const String& str,
+ intptr_t external_size,
void* peer,
Dart_PeerFinalizer cback);
@@ -7051,6 +7052,7 @@ class TwoByteString : public AllStatic {
Heap::Space space);
static void SetPeer(const String& str,
+ intptr_t external_size,
void* peer,
Dart_PeerFinalizer cback);
@@ -7896,7 +7898,9 @@ class ExternalTypedData : public Instance {
#undef TYPED_GETTER_SETTER
FinalizablePersistentHandle* AddFinalizer(
- void* peer, Dart_WeakPersistentHandleFinalizer callback) const;
+ void* peer,
+ Dart_WeakPersistentHandleFinalizer callback,
+ intptr_t external_size) const;
static intptr_t length_offset() {
return OFFSET_OF(RawExternalTypedData, length_);
« no previous file with comments | « runtime/vm/dart_api_impl.cc ('k') | runtime/vm/object.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698