runtime/vm/clustered_snapshot.cc - Issue 2275803002: Assign external sizes to external strings and to external typed data created by the VM.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: runtime/vm/clustered_snapshot.cc

Issue 2275803002: Assign external sizes to external strings and to external typed data created by the VM. (Closed) Base URL: git@github.com:dart-lang/sdk.git@master

Patch Set: sync Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: runtime/vm/clustered_snapshot.cc

diff --git a/runtime/vm/clustered_snapshot.cc b/runtime/vm/clustered_snapshot.cc

index fe51886ac87998be4b73753989fbdea474dab07b..0601dae560a6c4ffd33d227a8668ee428fd8edc7 100644

--- a/runtime/vm/clustered_snapshot.cc

+++ b/runtime/vm/clustered_snapshot.cc

@@ -3552,6 +3552,7 @@ class ExternalTypedDataDeserializationCluster : public DeserializationCluster {

data->ptr()->length_ = Smi::New(length);

data->ptr()->data_ = const_cast<uint8_t*>(d->CurrentBufferAddress());

d->Advance(length * element_size);

+ // No finalizer / external size 0.

}

« no previous file with comments | « runtime/include/dart_api.h ('k') | runtime/vm/dart_api_impl.cc » ('j') | no next file with comments »