Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(121)

Issue 22758002: Fix a crash in SSL under memory pressure (Closed)

Created:
7 years, 4 months ago by Ryan Sleevi
Modified:
7 years, 4 months ago
Reviewers:
wtc
CC:
chromium-reviews, cbentzel+watch_chromium.org
Visibility:
Public.

Description

Fix a crash in SSL under memory pressure BUG=270735 R=wtc Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=217083

Patch Set 1 #

Total comments: 2

Patch Set 2 : Review feedback #

Unified diffs Side-by-side diffs Delta from patch set Stats (+27 lines, -1 line) Patch
M net/third_party/nss/README.chromium View 1 1 chunk +4 lines, -0 lines 0 comments Download
M net/third_party/nss/patches/applypatches.sh View 1 chunk +2 lines, -0 lines 0 comments Download
A net/third_party/nss/patches/sslsock_903565.patch View 1 1 chunk +20 lines, -0 lines 0 comments Download
M net/third_party/nss/ssl/sslsock.c View 1 2 chunks +1 line, -1 line 0 comments Download

Messages

Total messages: 6 (0 generated)
Ryan Sleevi
wtc: easy fix. Guessing simple merge bug.
7 years, 4 months ago (2013-08-09 19:51:24 UTC) #1
wtc
Patch set 1 LGTM. https://codereview.chromium.org/22758002/diff/1/net/third_party/nss/patches/applypatches.sh File net/third_party/nss/patches/applypatches.sh (right): https://codereview.chromium.org/22758002/diff/1/net/third_party/nss/patches/applypatches.sh#newcode49 net/third_party/nss/patches/applypatches.sh:49: patch -p5 < $patches_dir/sslsock_903565.patch This ...
7 years, 4 months ago (2013-08-09 21:34:41 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rsleevi@chromium.org/22758002/3002
7 years, 4 months ago (2013-08-09 22:35:48 UTC) #3
commit-bot: I haz the power
Step "update" is always a major failure. Look at the try server FAQ for more ...
7 years, 4 months ago (2013-08-09 22:58:51 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rsleevi@chromium.org/22758002/3002
7 years, 4 months ago (2013-08-12 19:42:06 UTC) #5
commit-bot: I haz the power
7 years, 4 months ago (2013-08-12 21:38:31 UTC) #6
Message was sent while issue was closed.
Change committed as 217083

Powered by Google App Engine
This is Rietveld 408576698