Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(167)

Issue 2275783002: Turn Mash Window Example Context Menu Async (Closed)

Created:
4 years, 4 months ago by jonross
Modified:
4 years, 3 months ago
Reviewers:
sky
CC:
chromium-reviews, kalyank, sadrul
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Turn Mash Window Example Context Menu Async Update the mash windowing example app to use async context menus. TEST=manually test example app BUG=557136 Committed: https://crrev.com/bcfe72415a70aec446cb2cc784441aeb70b0e433 Cr-Commit-Position: refs/heads/master@{#414470}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -8 lines) Patch
M mash/example/window_type_launcher/window_type_launcher.cc View 1 chunk +4 lines, -8 lines 0 comments Download

Messages

Total messages: 12 (7 generated)
jonross
Hey sky@ could you PTAL? Thanks, Jon
4 years, 3 months ago (2016-08-25 13:34:17 UTC) #6
sky
LGTM
4 years, 3 months ago (2016-08-25 16:10:44 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2275783002/1
4 years, 3 months ago (2016-08-25 16:55:20 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 3 months ago (2016-08-25 18:06:50 UTC) #10
commit-bot: I haz the power
4 years, 3 months ago (2016-08-25 18:08:43 UTC) #12
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/bcfe72415a70aec446cb2cc784441aeb70b0e433
Cr-Commit-Position: refs/heads/master@{#414470}

Powered by Google App Engine
This is Rietveld 408576698