core/fpdfapi/fpdf_parser/cpdf_document.cpp - Issue 2275773003: Flip document and parser ownership

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: core/fpdfapi/fpdf_parser/cpdf_document.cpp

Issue 2275773003: Flip document and parser ownership (Closed) Base URL: https://pdfium.googlesource.com/pdfium.git@private_parser

Patch Set: Rebase to master Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: core/fpdfapi/fpdf_parser/cpdf_document.cpp

diff --git a/core/fpdfapi/fpdf_parser/cpdf_document.cpp b/core/fpdfapi/fpdf_parser/cpdf_document.cpp

index b11d0c1b791fbc98cb873e613e652d0be0c42e37..89b41d5820d302d8937cfb915e0a46931a1a5661 100644

--- a/core/fpdfapi/fpdf_parser/cpdf_document.cpp

+++ b/core/fpdfapi/fpdf_parser/cpdf_document.cpp

@@ -483,9 +483,9 @@ int CountPages(CPDF_Dictionary* pPages,

} // namespace

-CPDF_Document::CPDF_Document(CPDF_Parser* pParser)

+CPDF_Document::CPDF_Document(std::unique_ptr<CPDF_Parser> pParser)

: CPDF_IndirectObjectHolder(),

- m_pParser(pParser),

+ m_pParser(std::move(pParser)),

m_pRootDict(nullptr),

m_pInfoDict(nullptr),

m_bLinearized(false),

« no previous file with comments | « no previous file | core/fpdfapi/fpdf_parser/cpdf_parser.cpp » ('j') | no next file with comments »